Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up IMessageBox #4042

Closed
Vogel612 opened this issue May 26, 2018 · 1 comment
Closed

Clean up IMessageBox #4042

Vogel612 opened this issue May 26, 2018 · 1 comment
Assignees
@Vogel612
Labels
difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. technical-debt This makes development harder or is leftover from a PullRequest. Needs to be adressed at some point.
Projects
CodeName: Cucumber

Comments

@Vogel612
Copy link
Member

IMessageBox was changed up a bit in #4006

While that was not the general intention of the PR, some cruft remains, namely the bool? parameter and return value on Confirm as well as the missing caption argument on Message.

The bool? should be replaced with a thin wrapper over the DialogResult members Yes, No and Cancel.

Message should get a (possibly optional?) parameter caption. If necessary, callsites need to be updated.
@Vogel612 Vogel612 added enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. technical-debt This makes development harder or is leftover from a PullRequest. Needs to be adressed at some point. difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. labels May 26, 2018
@Vogel612 Vogel612 mentioned this issue May 26, 2018
Closed
@Vogel612 Vogel612 self-assigned this May 26, 2018
@Vogel612 Vogel612 added this to TODO in CodeName: Cucumber May 26, 2018
Vogel612 added a commit to Vogel612/Rubberduck that referenced this issue May 26, 2018
@Vogel612
Update IMessageBox Api for Confirmation, see rubberduck-vba#4042
c45bba8
@Vogel612 Vogel612 moved this from TODO to In Progress in CodeName: Cucumber May 26, 2018
mansellan pushed a commit to mansellan/Rubberduck that referenced this issue Jun 23, 2018
@Vogel612 @mansellan
Update IMessageBox Api for Confirmation, see rubberduck-vba#4042
0930865
@Vogel612
Copy link
Member Author

Fixed as of #4044

CodeName: Cucumber automation moved this from In Progress to Done Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vogel612 Vogel612

Labels
difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. technical-debt This makes development harder or is leftover from a PullRequest. Needs to be adressed at some point.
Projects
CodeName: Cucumber
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Vogel612