Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoComplete interference with IntelliSense auto complete #4087

Closed
daFreeMan opened this issue Jun 14, 2018 · 5 comments
Closed

AutoComplete interference with IntelliSense auto complete #4087

daFreeMan opened this issue Jun 14, 2018 · 5 comments
Assignees
Labels
bug Identifies work items for known bugs critical Marks a bug as a must-fix, showstopper issue feature-autocomplete
Milestone

Comments

@daFreeMan
Copy link
Contributor

daFreeMan commented Jun 14, 2018

Build .3384

I've enabled {Tab} for RD AC.

Within a With block, I was adding a new line. Concatenating a String variable to the end of a text string I started with this:
rd ac intellisense 1

I hit {Tab} and ended up with this:
rd ac intellisense 2

This is somewhat inconsistent (ain't those the best?) - the first couple of times, I got no completion. However, setting up to get the first screen grab, I hit Tab and it worked just fine. It was then, though, that I realized that the extra Wends (I had 2 from testing it twice to be sure of what I was seeing) had been inserted (I had 2 at that point). I cleaned up the code back to my starting condition, and was able to reliable reproduce it to get the 2nd screen grab.

This could, potentially, be related to the fact that the code is currently executing, but "well... don't do that" isn't a reasonable fix - a lot of people do do that.

Hitting Enter seems to be a pretty reliable way to get IntelliSense to AC without triggering the RD AC issue. ("Pretty" reliable, because I haven't tested it more than 2 or 3 times...)

@retailcoder
Copy link
Member

Hold on hold on hold on... you managed to get a Wend autocompleted off a With block???

@daFreeMan
Copy link
Contributor Author

Yeah, that took a minute to sink in... see #4088

@retailcoder
Copy link
Member

There's not really a way to tell, right now, whether an IntelliSense popup is being shown (and thus whether to yield any TAB hit to that popup). Presumably there's a WM message somewhere to pick up & handle for that. As for AC not firing, I suspect #4080.

@Vogel612 Vogel612 added bug Identifies work items for known bugs feature-autocomplete critical Marks a bug as a must-fix, showstopper issue labels Jun 15, 2018
@Vogel612
Copy link
Member

labelling critical because of the resulting code breakage

@retailcoder
Copy link
Member

@Vogel612 intellisense does get in the way, but not as much as it seems from this issue: the real problem here is that AC picked up a While keyword in a string literal on the current line, so hitting TAB triggered AC and added the corresponding Wend - IMO triggering AC on string literals (and end-of-line comments) is the critical showstopper issue here; blocking AC when intellisense is shown would only have coincidentally prevented this.

Not saying AC interfering with intellisense isn't a problem, but in this specific case intellisense is just a distraction.

With foo.B{TAB}

Would have the TAB keypress eaten by AC, resulting in:

With foo.B
    |
End With

Which is bad, but not critically broken IMO.

@Vogel612 Vogel612 added this to the 2.3.0 Release milestone Jun 20, 2018
@Vogel612 Vogel612 added this to TODO in Release 2.3.0 Jun 20, 2018
@retailcoder retailcoder self-assigned this Jun 22, 2018
Release 2.3.0 automation moved this from TODO to Done Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies work items for known bugs critical Marks a bug as a must-fix, showstopper issue feature-autocomplete
Projects
Release 2.3.0
  
Done
Development

No branches or pull requests

3 participants