Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename clash check is a little too tight. #4349

Closed
daFreeMan opened this issue Sep 4, 2018 · 2 comments · Fixed by #4371
Closed

Rename clash check is a little too tight. #4349

daFreeMan opened this issue Sep 4, 2018 · 2 comments · Fixed by #4371
Labels
bug Identifies work items for known bugs refactoring-rename

Comments

@daFreeMan
Copy link
Contributor

Win10, Excel201(Desktop), RD .3744

Given this code:

Private Type TMonthScoreInfo
  veryDissatisfiedResponses As Long
End Type
Private this As TMonthScoreInfo

Public Property Get VS() As Long
  VS = this.verySatisfiedResponses
End Property
Public Property Let VS(ByVal theVal As Long)
  this.verySatisfiedResponses = theVal
End Property

ARefactor | Rename attempt on Public Property Get VS() As Long to Public Property Get verySatisfiedResponses() As Long yields a warning that there is a name clash on verySatisfiedResponses
2018-09-04 14_13_28-microsoft visual basic for applications - satisfaction summary master v3 23 - de
however there really isn't. Clicking "Yes" completes the rename and the code compiles cleanly

@Vogel612 Vogel612 added bug Identifies work items for known bugs refactoring-rename labels Sep 4, 2018
@Vogel612 Vogel612 added this to ToDo in Semi-automatic bug tracker via automation Sep 4, 2018
Semi-automatic bug tracker automation moved this from ToDo to Done Oct 11, 2018
@comintern
Copy link
Contributor

See chat.

@comintern comintern reopened this Nov 5, 2018
Semi-automatic bug tracker automation moved this from Done to In Progress Nov 5, 2018
@daFreeMan
Copy link
Contributor Author

I just noticed that doing the rename in the opposite order - i.e. rename the member of Type, then rename the Getter/Setter it works without error.

Semi-automatic bug tracker automation moved this from In Progress to Done Nov 16, 2018
@Vogel612 Vogel612 modified the milestone: 2.4.1 Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies work items for known bugs refactoring-rename
Projects
Development

Successfully merging a pull request may close this issue.

3 participants