Fixes 4349...take two #4520
Fixes 4349...take two #4520
Conversation
bclothier
added
the
PR-Status: Review Requested
| [Test] | ||
| [Category("Refactorings")] | ||
| [Category("Rename")] | ||
| public void RenameRefactoring_DoesNotWarnForMember_Issue4349() |
There was a problem hiding this comment.
This is a question to @rubberduck-vba/contributors -- do we have any consensus on whether the issue # should be embedded in the test? I get the benefit but I would normally put them in a comment rather than in the name.
There was a problem hiding this comment.
I generally prefer a hyperlink to the issue in a comment above the test if for no other reason that usability.
There was a problem hiding this comment.
I vote keeping issues and their URL links in comments as I believe improves/strengthens our Test driven culture for RD with better evidence tracking for regression anaylsis if need be.
Are there any limitation of how long the URL be kept in comments similar to 255 characters if so, any shortening URL thoughts?
There was a problem hiding this comment.
I'm in agreement with using a hyperlink to the issue in a comment...and have updated the tests accordingly.
Recorded issue as comment with hyperlink
Resolves #4349. Removes Enums/UDTs rename conflict detection false-positive.
Added a failing repro test for last reported false-positive and some tweaks to the VBA input code for prior #4349 tests.