Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get UnitTesting internals out of Rubberduck.Core #4365

Closed
Vogel612 opened this issue Sep 13, 2018 · 0 comments · Fixed by #4769
Closed

Get UnitTesting internals out of Rubberduck.Core #4365

Vogel612 opened this issue Sep 13, 2018 · 0 comments · Fixed by #4769
Assignees
@Vogel612 @comintern
Labels
development-issue Issues encountered while developing RD, not in RD itself enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-unit-testing technical-debt This makes development harder or is leftover from a PullRequest. Needs to be adressed at some point.
Projects
CodeName: Cucumber Release 2.4.1
Milestone
2.4.1

Comments

@Vogel612
Copy link
Member

There's some stuff in Rubberduck.Core that does no longer belong there, but which was too disjoint from #4146 to be pushed into there.

As such this is a follow-up issue to deal with the following more or less gaping issues:

  • IVBEInteraction is used outside of UnitTesting
  • AddTestModule command builds it's own template
  • AddTestMethod and AddTestMethodExpectedError don't call into UnitTesting to determine the next test name

Generally the internal API to Rubberduck should be consistent and cleanly exposed and separated into the Rubberduck.UnitTesting assembly
@Vogel612 Vogel612 added enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-unit-testing technical-debt This makes development harder or is leftover from a PullRequest. Needs to be adressed at some point. development-issue Issues encountered while developing RD, not in RD itself labels Sep 13, 2018
@Vogel612 Vogel612 self-assigned this Sep 13, 2018
@Vogel612 Vogel612 added this to TODO in CodeName: Cucumber Oct 23, 2018
@comintern comintern self-assigned this Feb 4, 2019
comintern added a commit to comintern/Rubberduck that referenced this issue Feb 4, 2019
@comintern
Give Rubberduck.UnitTesting its stuff back. Closes rubberduck-vba#4365,
ccd51b1 
rubberduck-vba#4220, and rubberduck-vba#3879. Ref rubberduck-vba#4702
@comintern comintern mentioned this issue Feb 4, 2019
Merged
CodeName: Cucumber automation moved this from TODO to Done Feb 19, 2019
@Vogel612 Vogel612 added this to Done in Release 2.4.1 Feb 28, 2019
@Vogel612 Vogel612 added this to the 2.4.1 milestone Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vogel612 Vogel612

@comintern comintern

Labels
development-issue Issues encountered while developing RD, not in RD itself enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-unit-testing technical-debt This makes development harder or is leftover from a PullRequest. Needs to be adressed at some point.
Projects
CodeName: Cucumber
  
Done
Release 2.4.1
  
Done
Milestone
2.4.1
Development

Successfully merging a pull request may close this issue.

Refresh Testing (Pun Intended) comintern/Rubberduck
2 participants
@Vogel612 @comintern