Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShadowedDeclarationInspection description text should mention fully qualified identifiers #4609

Closed
Inarion opened this issue Dec 5, 2018 · 0 comments
Closed

ShadowedDeclarationInspection description text should mention fully qualified identifiers #4609

Inarion opened this issue Dec 5, 2018 · 0 comments
Assignees
@Inarion
Labels
difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-inspections up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky user-documentation This issue relates to feature documentation that is exposed by Rubberduck or on the website / wiki
Milestone
2.x Cycle

Comments

@Inarion
Copy link
Contributor

Inarion commented Dec 5, 2018

Currently, the English description is

Two declarations are in scope and have the same identifier name. This means that only one of them will be available to use.

This is true for unqualified identifiers, but certainly not for fully qualified identifiers. The description should mention that. (Even if it only serves to have a still-ignorant VBA newbie search for the term...)

This might even be a good place to offer the quickfix mentioned in #4194 (once it's implemented).
@Vogel612 Vogel612 added enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. user-documentation This issue relates to feature documentation that is exposed by Rubberduck or on the website / wiki labels Dec 5, 2018
@Inarion Inarion added feature-inspections enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. user-documentation This issue relates to feature documentation that is exposed by Rubberduck or on the website / wiki and removed difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky user-documentation This issue relates to feature documentation that is exposed by Rubberduck or on the website / wiki labels Dec 5, 2018
@Inarion Inarion self-assigned this Dec 5, 2018
@Vogel612 Vogel612 added the up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky label Dec 5, 2018
@Vogel612 Vogel612 added this to the 2.3.1 milestone Dec 5, 2018
@Inarion Inarion mentioned this issue Dec 5, 2018
Merged
@Vogel612 Vogel612 modified the milestones: 2.3.1, 2.4.0 Dec 11, 2018
@MDoerner MDoerner modified the milestones: 2.4.0, 2.x Cycle Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Inarion Inarion

Labels
difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. enhancement Feature requests, or enhancements to existing features. Ideas. Anything within the project's scope. feature-inspections up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky user-documentation This issue relates to feature documentation that is exposed by Rubberduck or on the website / wiki
Projects
None yet
Milestone
2.x Cycle
Development

No branches or pull requests
3 participants
@Vogel612 @MDoerner @Inarion