Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CodeBlockNode to determine indentation level? #51

Closed
retailcoder opened this issue Nov 19, 2014 · 1 comment
Closed

Use CodeBlockNode to determine indentation level? #51

retailcoder opened this issue Nov 19, 2014 · 1 comment

Comments

@retailcoder
Copy link
Member

The parsed code tree contains CodeBlockNode items, which should add an indentation level. Each node in the tree contains an Instruction which knows about its StartColumn, and each Instruction knows about a LogicalCodeLine, which knows about its StartLine.

Using the parsed code tree may seem like a good idea for the indenter, but there are complications:

  • A LogicalCodeLine can refer to more than 1 line of code
  • An Instruction may not be the only instruction on a code line; its StartColumn isn't necessarily its indentation level.

Indentation applies to code lines - not to logical code lines, not to instructions. Should the code tree be modified to accomodate this? Or should we find another way of determining code indentation?

@retailcoder retailcoder added this to the Auto-Indenter milestone Nov 19, 2014
@rubberduck203 rubberduck203 modified the milestones: Auto-Indenter, Future Versions Feb 10, 2015
@retailcoder
Copy link
Member Author

We're not using homebrewn Node classes since v1.22, and indentation will be handled by SmartIndenter. This issue is moot.

@retailcoder retailcoder removed this from the Future Versions milestone Sep 22, 2015
@retailcoder retailcoder added the status-declined This will not be implemented. label Sep 22, 2015
retailcoder added a commit that referenced this issue Feb 28, 2016
sync with merged PR's in main repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants