Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference Explorer #1991

Closed
wants to merge 10 commits into from
Closed

Reference Explorer #1991

wants to merge 10 commits into from

Conversation

rossknudsen
Copy link

Hi guys,

Have a look at this and see what you think. There are probably a few bugs to work out. There is an issue with RD I believe where the ActiveProject changes as the dialog is opened which causes some unexpected behaviour.

Rossco

@@ -67,6 +68,7 @@ public override void Load()
Bind<RubberduckCommandBar>().ToSelf().InSingletonScope();
Bind<TestExplorerModel>().ToSelf().InSingletonScope();
Bind<IOperatingSystem>().To<WindowsOperatingSystem>().InSingletonScope();
Bind<RegisteredLibraryModelService>().To<RegisteredLibraryModelService>().InSingletonScope();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind fixing your indentation?

@Hosch250
Copy link
Member

Hosch250 commented Jul 8, 2016

No C# 6 features, please. That means no get-only properties without a body, no null-checking ? operators (I forget the name), and no nameof.

@retailcoder
Copy link
Member

I have this PR in my fork, working on the UI and turning it into a dialog - there shouldn't be any actual action done on the active project until the dialog is okayed. Not rushing though, this is a 2.1 feature.

@rossknudsen I didn't dig too deep into that COM reflection package, but could it be used to move code out from our COM collector? Or is it just to get the list of registered COM libraries and types?

@rossknudsen
Copy link
Author

Sorry @retailcoder , I've been really ill the past couple of weeks, which is why this hasn't gone anywhere. I had been working on the dialog but I'm not sure I pushed everything up to my fork, so we are probably out of sync now :-(.

It may be easier for me to start from a fresh pull from your branch rather than try and merge my changes now. Let me know which branch you've got it in.

@rossknudsen
Copy link
Author

Oh and to answer your other question. The code in the COM reflection package could be used to replace some of the code in the 'COM collector'. However, the code is pretty green.

I recommend waiting until the Reference Browser is working well, having all the bugs ironed out. I've got a sneaking suspicion that I am doing something wrong in enumerating registry keys using yield return.

@rossknudsen rossknudsen deleted the feature/Com_Reference_Explorer branch March 7, 2017 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants