Exception handling for unit tests and more #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…setup if there is something to load.
retailcoder
reviewed
Mar 14, 2017
|
|
||
| var referenceLoadingTaskScheduler = ThrottelingTaskScheduler(_maxReferenceLoadingConcurrency); | ||
| State.OnStatusMessageUpdate(ParserState.LoadingReference.ToString()); |
There was a problem hiding this comment.
Shouldn't this get the localized resource for the ParserState.LoadingReference state? The InspectionUI resources will be moving to the Rubberduck.Parsing assembly; perhaps the ParserState enum resources should be moved to ParsingText.resx?
retailcoder
reviewed
Mar 14, 2017
| @@ -839,22 +839,12 @@ private void SyncComReferences(IReadOnlyList<IVBProject> projects, CancellationT | |||
| var unmapped = new ConcurrentBag<IReference>(); | |||
|
|
|||
| var referencesToLoad = GetReferencesToLoadAndSaveReferencePriority(projects); | |||
|
|
|||
| State.OnStatusMessageUpdate(ParserState.LoadingReference.ToString()); | |||
There was a problem hiding this comment.
And I just realized why that "Loading references" caption didn't follow the localization settings...
retailcoder
reviewed
Mar 14, 2017
| @@ -6,6 +6,8 @@ namespace Rubberduck.VBEditor.Application | |||
| { | |||
| public class ExcelApp : HostApplicationBase<Microsoft.Office.Interop.Excel.Application> | |||
| { | |||
| public const int MaxPossibleLengthOfProcedureName = 255; | |||
There was a problem hiding this comment.
We might want to have that one in HostApplicationBase, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This and that:
Slightly more safety for long procedure names in Excel. (If > 255 chars, drop the filename.)
Catching and logging of COMExceptions thrown during running the unit tests. (
Application.Runmight not like what we are feeding it.) Exception gets logged and test gets set toInconclusive - Unexpected COM error.Small refactoring of
SyncCOMReferencesin theParseCoordinator. Now, the setup for parallelism gets only performed if there is actually soemthing to load.