Follow on work to DeclarationFinder.GetDeclarationsWithIdentifiersToAvoid(...) #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-vba/next' into next
…k-vba/next' into next
…ba/next' into next
… failures after rubberduck-vba#2861 is fixed
retailcoder
reviewed
Mar 17, 2017
| @@ -455,5 +522,308 @@ private static void AddReference(Declaration toDeclaration, Declaration fromModu | |||
| { | |||
| toDeclaration.AddReference(toDeclaration.QualifiedName.QualifiedModuleName, fromModuleDeclaration, fromModuleDeclaration, context, toDeclaration.IdentifierName, toDeclaration, Selection.Home, new List<Rubberduck.Parsing.Annotations.IAnnotation>()); | |||
| } | |||
|
|
|||
| #region AccessibilityTests_HardcodedModuleContent | |||
There was a problem hiding this comment.
You're onto something here, I like this very much - not the #region, but the idea of pulling the code content - our "data" - from the tests is awesome.
I'll bring in your PR, and then let's refactor them into their own static class with a bunch of expression-bodied members that return a static readonly string - and eventually one "code" class for every test class... or hmm, one "repository" of VBA sample code to test against. @Hosch250 what do you think?
There was a problem hiding this comment.
OK - I'll take a shot at the static class.
BZngr
added a commit
to BZngr/Rubberduck
that referenced
this pull request
Mar 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances name conflict discovery during Rename-Refactoring. The discovery logic now accounts for name conflicts resulting from renaming an identifier where itself, it's declaration, or another reference would cause conflicts. See also #2817.