Initial implementation of Fakes framework. #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need a wiki page to document what the conventions are and how to extend the current functionality. |
|
@comintern only missing a commit on README.MD and the about dialog, to sing the praise of EasyHook :-) |
|
BTW the internal API looks beautiful - feels like extending this is going to be a charm! |
| [return: MarshalAs(UnmanagedType.IUnknown)] | ||
| private static extern object rtcErrObj(); | ||
|
|
||
| public static void RaiseVbaError(int number, string source = "", string description = "", string helpfile = "", int helpcontext = 0) |
There was a problem hiding this comment.
++ I don't know why we never thought of importing this before. I just want to point out that, more than ever, we need to stick to our guns about pre-2007 being unsupported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #2863, #2891
Consider this WIP. There are a couple of features that still aren't implemented, and it's only lightly tested at this point. That said, it would be nice to get it merged in that there are quite a few changed files and the merge commit is already promising to be unpleasant. If push comes to shove, it can easily be "switched off" by making the relevant members
ComVisible(false).