Parser Fix for LineNumberLovers #3217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-null for modules, which introduced (another) bug in SynchronizeAttributesQuickFix (WIP)
retailcoder
commented
Aug 3, 2017
| @@ -303,15 +303,15 @@ lastLetter : unrestrictedIdentifier; | |||
| doLoopStmt : | |||
MDoerner
reviewed
Aug 3, 2017
| caseElseClause? | ||
| END_SELECT | ||
| (statementLabelDefinition? whiteSpace? caseClause)* | ||
| statementLabelDefinition? whiteSpace? caseElseClause? |
There was a problem hiding this comment.
Does thin interfere with the quickfixes for the empty if block and empty else block inspections?
There was a problem hiding this comment.
hmm, very good question. needs a test.
There was a problem hiding this comment.
It shouldn't, actually - these aren't counted as executable ststements. Need to check if it interferes with the quickfix though...
There was a problem hiding this comment.
Hm, I put the comment at the wrong spot.
MDoerner
reviewed
Aug 3, 2017
| END_IF | ||
| (statementLabelDefinition? whiteSpace? elseIfBlock)* | ||
| (statementLabelDefinition? whiteSpace? elseBlock?) | ||
| statementLabelDefinition? whiteSpace? END_IF |
There was a problem hiding this comment.
This is where my first comment should have gone. The problem I see here is that the line number is not part of the elseif block or else block. That might cause problems with the quickfixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3216.