Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Issue 3507 run selected unit test #3638

Merged

Conversation

IvenBach
Copy link
Member

Close #3507. Allows single test to be run.

Should this be expanded to include multiple selected tests?

@IvenBach IvenBach changed the title Issue3507 run selected unit test Close Issue 3507 run selected unit test Dec 22, 2017
@Vogel612
Copy link
Member

I can find no reference to RunSelectedTestCommand. Is this F5 tested? If it is, did you forget to include a file?

Do note that the original intention of #3507 was to run selected tests. As such also the change to the i18n is an IMO incorrect change.
So to answer the question: yes it should be expanded to include multiple tests :)

@retailcoder
Copy link
Member

Hmm does the grid even allow for multiple selections (it should)?

@IvenBach
Copy link
Member Author

It was F5 tested and was working. The grid does allow for multiple selections. Only the first test selected would run, even when multiple tests were selected.

@retailcoder
Copy link
Member

retailcoder commented Dec 26, 2017

@IvenBach seems like bad UX - wouldn't we want to run all the selected tests? IMO either the grid allows for single selection and we run one selected test, or the grid allows for multiple selections and we run everything that's selected.

@IvenBach
Copy link
Member Author

I only re-implemented what was already in RD. I'll have to refactor to get it to run all the selected tests.

@retailcoder retailcoder merged commit 827e708 into rubberduck-vba:next Dec 27, 2017
@IvenBach IvenBach deleted the Issue3507_Run_selected_unit_test branch December 27, 2017 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants