Unify some duplicated codes and make them testable/mockable #3823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the DllVersion standalone Update namespace references
…whether it's a UI thread or not.
Provide an interface for UiDispatcher Make UiDispatcher injected via ctors for consuming classes
bclothier
added
the
PR-Status: Review Requested
…ead of newing it up.
…nto UnifyVbeFunctions # Conflicts: # RetailCoder.VBE/VBERuntime/IVBESettings.cs # RetailCoder.VBE/VBERuntime/RegistryWrapper.cs # RetailCoder.VBE/VBERuntime/VBESettings.cs # Rubberduck.Core/Rubberduck.Core.csproj # Rubberduck.Core/UI/Settings/SettingsForm.cs # Rubberduck.Core/VBERuntime/IVBESettings.cs # Rubberduck.Core/VBERuntime/RegistryWrapper.cs # Rubberduck.Core/VBERuntime/VBESettings.cs # Rubberduck.Main/Root/RubberduckIoCInstaller.cs # Rubberduck.VBEEditor/Utility/RegistryWrapper.cs # Rubberduck.VBEEditor/VBERuntime/Settings/IVBESettings.cs # Rubberduck.VBEEditor/VBERuntime/Settings/VBESettings.cs # RubberduckTests/Settings/GeneralSettingsTests.cs # RubberduckTests/VBE/VBESettingsTests.cs
MDoerner
reviewed
Mar 14, 2018
| if (UiContext == null) throw new InvalidOperationException("UiDispatcher is not initialized. Invoke Initialize() from UI thread first."); | ||
| if (_contextProvider.UiContext == null) | ||
| { | ||
| throw new InvalidOperationException("UiDispatcher is not initialized. Invoke Initialize() from UI thread first."); |
There was a problem hiding this comment.
This error message is misleading now. The UiContext is not initialized and Initialize has to be called on it, not on the dispatcher.
|
|
||
| public class UiContextProvider : IUiContextProvider | ||
| { | ||
| // thanks to Pellared on http://stackoverflow.com/a/12909070/1188513 |
There was a problem hiding this comment.
If at all any longer appropriate, this should probably be in the UiDispatcher as it most closely resembles the code from the post.
| public SynchronizationContext UiContext => Context; | ||
| public TaskScheduler UiTaskScheduler => TaskScheduler; | ||
|
|
||
| public bool CheckContext() |
There was a problem hiding this comment.
I would prefer a more descriptive name likem CurrentContextIsUiContext or IsExecutingInUiContext. The current name does not really convey what is checked.
bclothier
removed
the
PR-Status: Review Requested
…lanatory comment to highlight the static methods being used for the VBEEvents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to cut down on the duplications that was created as consequence of recent PRs, namely:
We introduced both
VBESettingsandVBERuntime; but they had their own version check logic, and were originally in two different projects. I have moved everything toRubberduck.VBEEditorand separated out the version check logic.SynchronizationContextused byUiDispatcherandComMessagePumperinto a new class,UiContextProvider.This makes those 2 consuming classes mockable which will aid the testability of the dependent classes (though they themselves cannot be really tested). Furthermore, the
UiContextProvidercan be DI'd for any new consumers.