Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix release for 2.3.0 #4619

Merged
merged 96 commits into from Dec 10, 2018
Merged

Hotfix release for 2.3.0 #4619

merged 96 commits into from Dec 10, 2018

Conversation

retailcoder
Copy link
Member

No description provided.

comintern and others added 30 commits November 16, 2018 19:30
@comintern
Seal classes with explicit interface implementations. Addresses CA1033
9fa002d
@comintern
Rearrange Dispose methods to make MS happy. Addresses CA1063
1dd686f
@comintern
Change exceptions raised, addresses CA1065.
9a77667
@comintern
Don't call GetLastWin32Error in interpolated string. Addresses CA1404
71f2464
@comintern
Fix size of atoms, size_t parameters. Addresses CA1901
66c272c
@comintern
Avoid problems with multibytechar* by explicitly using unicode. Addre…
7a8e57d 
…sses CA2101
@comintern
Extend EventArgs, addresses CA1009
4d1f2db
@comintern
Change to internal visibility, addresses CA1401
5ac4ecf
@comintern
Suppress CA2202
5c1cd5a
@comintern
Remove redundant Dispose calls in using block. Addresses CA2202
a4d65e6
@comintern
Remove redundant Loggers. Addresses CS0108
5606073
@comintern
Fix debug logging.
ef02b69
@comintern
Fix missed cast to ushort on prior commit.
b5bb7cf
@comintern
Address review comments.
5c4b51c
@comintern
Suppress implement IDisposable warnings (CA1001).
2ee7b0a
@comintern
Suppress warnings - this should not be disposable
c414f37
@comintern
mergewith next
5c24424
@comintern
fix merge conflict
a0a59f5
@bclothier
Restore WinForms designer
d445c4b
@retailcoder
Merge pull request #4536 from bclothier/FixWinFormDesigner
d0bcf61 
Restore WinForms designer
@retailcoder
Merge pull request #4526 from comintern/next
b25e5be 
Cull build warnings
@MDoerner
Fix two premature disposals of SCWs
6c6791f 
The return inside using one is somewhat hiddeous.
@MDoerner
Some minor improvements in projects usage
74ae2dd
@MDoerner
Fix another premature disposal
2d0dfc2
@retailcoder
Merge pull request #4559 from MDoerner/FixSomeScwDisposal
bde616d 
Fix some scw disposal
@MDoerner
Add failing test for unexpected behaviour from issue #4558
62c4bd2
@MDoerner
Adjust tests for new IllegalAnnotations and annotation resolution spe…
2ba2ef8 
…cification

Currently, the what annotations are legal is not very intuitive. So, we will only put legal annotations on stuff. What is left are illegal annotations. This changes the counting for illegal references in identifiers and where the annotation sections for variables and members end.
@MDoerner
Make tests pass for new annotation scoping design
8c5f900 
Annotations only get scoped to recipients now for which they have a corresponding flag.
@MDoerner
Remove no longer required part of IllegalAnnotationInspection
400ff2f
@MDoerner
Merge branch 'next' into FixIllegalAnnotationInspection
908e76e
@retailcoder
Copy link
Member Author

retailcoder commented Dec 7, 2018 •
edited

Blocked by #4621 and this diff which fixes #4605

@retailcoder
Copy link
Member Author

Draft release notes completed

@retailcoder retailcoder mentioned this pull request Dec 7, 2018
Closed
@rkapka
Copy link
Contributor

rkapka commented Dec 9, 2018

The release notes page is not working for me (404).

@Vogel612
Copy link
Member

Vogel612 commented Dec 9, 2018 •
edited

@rkapka The release notes are recorded in a draft release. Because the branch moved after the notes were initially created, the URL to these notes also changed. Could you check this link for me?

If it doesn't work, I'll move the notes to a Discussion visible to all Members of the Rubberduck org

@retailcoder retailcoder merged commit 7e17257 into master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@retailcoder @rkapka @Vogel612 @comintern @bclothier @MDoerner @mansellan