Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidate inspection results after parsing #4695

Merged
merged 2 commits into from
Jan 7, 2019
Merged

Invalidate inspection results after parsing #4695

merged 2 commits into from
Jan 7, 2019

Commits on Jan 5, 2019

  1. Add a mechanism to ask an inspection result whether it gets invalidated 

    This commit introduces the method ChangesInvalidateResult on the IInspectionResult that returns whether a change of the specified modules makes the result invalid. The base implementation returns true if the module specified on the result gets invalidated or else forwards the request to the inspection to allow inspection specific handling.

Declaration- and IdentifierReferenceInspectionResults also get invalidated based on the state they carry. AggregateInspectionResults are always considered invalidated as there is no way to see the individual results.
    @MDoerner
    MDoerner committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    bade5bc View commit details
    Browse the repository at this point in the history

  2. Wire up inspection result invalidation in the InspectionResultsViewModel 

    The invalidation is currently only used if the inspections do not get run; running the inspections overwrites the collection anyway.

Moreover, currently all results get invalidated unconditionally.
    @MDoerner
    MDoerner committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    d372794 View commit details
    Browse the repository at this point in the history