-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the persistence services #4699
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a97a021
Clean up the persistence services and make it use PersistancePathProv…
bclothier 5fe9af8
Fix the FailedLoadReturnValue
bclothier c44d6df
Refactor the XmlPersistanceService to use PersistancePathProvider
bclothier 4b98540
Refactor the SettingsViewModelBase and its implementations, and dry t…
bclothier 2efc2a1
Update the startup and the IoC registration
bclothier bce77cb
Update the unit tests
bclothier 6bef6a0
Unbreak the experimental types feature
bclothier 4130256
Merge branch 'next' of https://github.com/rubberduck-vba/Rubberduck i…
bclothier 76bc358
Merge branch 'next' of https://github.com/rubberduck-vba/Rubberduck i…
bclothier e3d276f
Merge branch 'next' of https://github.com/rubberduck-vba/Rubberduck i…
bclothier File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
|
||
namespace Rubberduck.Settings | ||
{ | ||
public interface IExperimentalTypesProvider | ||
{ | ||
IReadOnlyList<Type> ExperimentalTypes { get; } | ||
} | ||
|
||
public class ExperimentalTypesProvider : IExperimentalTypesProvider | ||
{ | ||
public IReadOnlyList<Type> ExperimentalTypes { get; } | ||
|
||
public ExperimentalTypesProvider(IEnumerable<Type> experimentalTypes) | ||
{ | ||
ExperimentalTypes = experimentalTypes.ToList().AsReadOnly(); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda want to be able to automatically discover these at some point ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed - that should be a language service class or something. Which should be its own PR, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, that one is definitely out of scope for the current PR