Invert project order for RD.CodeAnalysis and make RD.SettingsProvider more useful #4914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For that purpose we cleaned up Settings and their loading behaviour a bit and moved most of the interfaces relating to it into Rubberduck.SettingsProvider. The Defaults are now loaded differently, registration is probably utterly broken, though. Furthermore this extracts the CodeInspectionSettings defaults to RD.CodeAnalysis to make them accessible for the loader there.
MDoerner
reviewed
Apr 13, 2019
This moves the Consumer-Visible interfaces for Settings into the SettingsProvider project. Additionally a base-implementation for a ConfigurationService is provided. It uses a clear reflection-based mechanism to load the defaults for a given settings type from a settings class. The type is provided as a Type-Argument to the constructor. This structure should allow easily extensible and customizable settings loading with caching and defaults.
Codecov Report
@@ Coverage Diff @@
## next #4914 +/- ##
==========================================
+ Coverage 64.55% 64.56% +0.01%
==========================================
Files 1063 1065 +2
Lines 35564 35573 +9
==========================================
+ Hits 22955 22965 +10
+ Misses 12609 12608 -1
|
|
This PR adresses the I/O stall observed in #4905 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up Settings and their loading behaviour a bit and moves most of the interfaces relating to it into Rubberduck.SettingsProvider.
The Defaults are now loaded differently, registration is probably utterly broken, though.
Furthermore this extracts the CodeInspectionSettings defaults to RD.CodeAnalysis to make them accessible for the loader there.
It also inverts the project interdependence between RD.Core and RD.CodeAnalysis in preparation for a new large feature involving dependency graphs.
As it stands the Defaults need a bit of cleanup and revisiting of the loading mechanism they use. This should unify how settings work and make specialized SettingsProviders superfluous (or at least significantly easier to implement)