Fix attributes encoding issue #4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was always the case in debug.
Codecov Report
@@ Coverage Diff @@
## next #4937 +/- ##
==========================================
+ Coverage 64.48% 64.48% +<.01%
==========================================
Files 1070 1070
Lines 35697 35697
==========================================
+ Hits 23017 23018 +1
+ Misses 12680 12679 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
First, it fixes the oversight that the export encoding was not specified when substituting code via a file.
ref #4906
Second, it restricts tracing of the
ComSafeto when the compilation constantTRACE_COM_SAFEis specified instead of tracing it on all debug builds. This makes testing performance easier while still keeping the possibility to trace if needed for some investigation.