Inspection warning about procedure coercion calls #5165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retailcoder
added
Status: Blocked by other issue
and removed
Status: Blocked by other issue
labels
Note that the parameterized versions are technically not procedure coercions, but indexed default member accesses.
MDoerner
force-pushed
the
ProcedureCoercionCallInspection
branch
from
ff6966b
to
6ca5b84
Compare
|
LGTM; just one suggestion - In test cases we consider only the scenario of |
retailcoder
reviewed
Oct 2, 2019
Rubberduck.CodeAnalysis/Inspections/ObjectWhereProcedureIsRequiredInspection.cs
Outdated
Show resolved
Hide resolved
retailcoder
reviewed
Oct 2, 2019
Rubberduck.CodeAnalysis/Inspections/ObjectWhereProcedureIsRequiredInspection.cs
Show resolved
Hide resolved
retailcoder
reviewed
Oct 2, 2019
MDoerner
added a commit
to MDoerner/Rubberduck
that referenced
this pull request
Oct 2, 2019
Updates are based on review comments to PR rubberduck-vba#5165.
bclothier
reviewed
Oct 2, 2019
Updates are based on review comments to PR rubberduck-vba#5165.
MDoerner
force-pushed
the
ProcedureCoercionCallInspection
branch
from
0e15f77
to
ba80ad9
Compare
retailcoder
reviewed
Oct 3, 2019
| /// Identifies places in which an object is used but a procedure is required and a default member exists on the object. | ||
| /// </summary> | ||
| /// <why> | ||
| /// Providing an object in a place in which a procedure is required leads to a call to the objects default member. |
There was a problem hiding this comment.
Suggested change
| /// Providing an object in a place in which a procedure is required leads to a call to the objects default member. | |
| /// Providing an object where a procedure is required leads to an implicit call to the object's default member. |
retailcoder
reviewed
Oct 3, 2019
| /// </summary> | ||
| /// <why> | ||
| /// Providing an object in a place in which a procedure is required leads to a call to the objects default member. | ||
| /// This behavior is not obvious and most likely an error. |
There was a problem hiding this comment.
Suggested change
| /// This behavior is not obvious and most likely an error. | |
| /// This behavior is not obvious, and most likely unintended. |
Based on further comments on PR rubberduck-vba#5165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
ObjectWhereProcedureIsRequiredInspectionwarns about places in which a procedure coercion takes place, i.e. places in which an object is provided in a call statement. This leads to a call to the default member, provided it is a procedure or function or the default member cannot be bound at compile time. (Properties yield a compilation error, since they are not allowed in call statements.) This type of indirection is next to never really necessary and much more likely is caused by erroneously forgetting a member call.This PR also provides the
ExpandDefaultMemberQuickFiz, which does the obvious thing. Note that it will always expand the full default member chain for recursive default member reolutions. Moreover, it is deactivated for any such chain that cannot fully be bound at compile time. This is the first step towards fixing issue #2504; just the corresponding inspection is missing.NOTE:
Because of the infrastructure introduced in PR #5164, this PR is based on it. Please do not merge before that PR. I will rebase this one once the other PR is merged.