Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add access keys for settings window #5409

Merged
merged 7 commits into from May 15, 2021
Merged

Add access keys for settings window #5409

merged 7 commits into from May 15, 2021

Conversation

IvenBach
Copy link
Member

@IvenBach IvenBach commented Mar 3, 2020

Close #5408. Access keys can be changed to match the pond hive mind preference.

The SearchBox control doesn't get focus with with the assigned access key. Need to figure out how to get it to work still.

@IvenBach IvenBach added the PR-Status: WIP Pull request is work-in-progress, more commits should be expected. label Mar 3, 2020
@codecov
Copy link

codecov bot commented Mar 3, 2020 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (next@e498d95). Click here to learn what that means.
The diff coverage is 85.84%.

@@           Coverage Diff           @@
##             next    #5409   +/-   ##
=======================================
  Coverage        ?   61.26%           
=======================================
  Files           ?     1176           
  Lines           ?    40333           
  Branches        ?     8536           
=======================================
  Hits            ?    24710           
  Misses          ?    13821           
  Partials        ?     1802
Impacted Files Coverage Δ
Rubberduck.CodeAnalysis/CodeMetrics/CodeMetric.cs 33.33% <ø> (ø)
...berduck.CodeAnalysis/CodeMetrics/CodeMetricBase.cs 92.31% <ø> (ø)
...uck.CodeAnalysis/CodeMetrics/NestingLevelMetric.cs 66.67% <ø> (ø)
...ions/Concrete/BooleanAssignedInIfElseInspection.cs 85.29% <ø> (ø)
...s/Inspections/Concrete/EmptyCaseBlockInspection.cs 100.00% <ø> (ø)
...s/Inspections/Concrete/EmptyElseBlockInspection.cs 100.00% <ø> (ø)
...nspections/Concrete/EmptyForEachBlockInspection.cs 100.00% <ø> (ø)
...nspections/Concrete/EmptyForLoopBlockInspection.cs 100.00% <ø> (ø)
...sis/Inspections/Concrete/EmptyIfBlockInspection.cs 100.00% <ø> (ø)
...spections/Concrete/EmptyStringLiteralInspection.cs 100.00% <ø> (ø)
... and 225 more

@MDoerner
Copy link
Contributor

Is this PR really still WIP as the label suggests?

@MDoerner
Copy link
Contributor

MDoerner commented Jul 3, 2020

@IvenBach Is this still WIP as the label suggests or can we merge this?

@IvenBach
Copy link
Member Author

IvenBach commented Jul 3, 2020

I think WIP can be removed. I need to review it this weekend to remember what I did to be certain.

@IvenBach IvenBach removed the PR-Status: WIP Pull request is work-in-progress, more commits should be expected. label Jul 9, 2020
@retailcoder
Copy link
Member

I'd like this PR merged for the 2.5.1 release.

@MDoerner
Copy link
Contributor

Putting this into the release will require some additional non-trivial translation work.

@retailcoder
Copy link
Member

@MDoerner ok let's skip it then - the translations are good to go (a few CZ entries need attention, but nothing major)

@retailcoder retailcoder added the PR-Status: Conflicting PR can't be merged as it stands, conflicts must be resolved by the author. label Aug 24, 2020
@IvenBach IvenBach closed this Oct 30, 2020
@IvenBach IvenBach deleted the Issue5408_SettingsWindowAccessKeys branch October 30, 2020 16:23
@IvenBach IvenBach restored the Issue5408_SettingsWindowAccessKeys branch October 30, 2020 16:34
@IvenBach
Copy link
Member Author

Unintended close.

@IvenBach IvenBach reopened this Oct 30, 2020
@IvenBach
Copy link
Member Author

IvenBach commented Nov 6, 2020

This PR will be blocked by my other resource migrations. Will return to this once those are finalized and merged.

@retailcoder retailcoder merged commit e3aa19c into rubberduck-vba:next May 15, 2021
@IvenBach IvenBach deleted the Issue5408_SettingsWindowAccessKeys branch October 15, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR-Status: Conflicting PR can't be merged as it stands, conflicts must be resolved by the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add access keys to settings window
3 participants
@IvenBach @MDoerner @retailcoder