-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Folder Refactoring #5438
Move to Folder Refactoring #5438
Commits on Mar 20, 2020
-
Also correctly converts folder annotation arguments to the string content and back. This also removes the parentheses around folders.
Configuration menu - View commit details
-
Copy full SHA for 8a992ee - Browse repository at this point
Copy the full SHA 8a992eeView commit details -
Fix WriteOnlyPropertyInspection
It did not consider that there could be a getter in another module with the same name.
Configuration menu - View commit details
-
Copy full SHA for 213822f - Browse repository at this point
Copy the full SHA 213822fView commit details
Commits on Mar 21, 2020
-
Add MoveContainingFolderRefactoring
It moves the containing folder into another folder. Also fixes ToVbaStringLiteral. (It was missing the surrounding quotes.)
Configuration menu - View commit details
-
Copy full SHA for 7b2b173 - Browse repository at this point
Copy the full SHA 7b2b173View commit details -
Add tests for MoveToFolderRefactoring itself
Also adds members to get the initial model to InteractiveRefactoringTestsBase.
Configuration menu - View commit details
-
Copy full SHA for 50299d8 - Browse repository at this point
Copy the full SHA 50299d8View commit details -
Add tests for MoveContainingFolderRefactoring itself
There are already tests for the involved refactoring actions.
Configuration menu - View commit details
-
Copy full SHA for f17b1f7 - Browse repository at this point
Copy the full SHA f17b1f7View commit details -
Introduce IRefactoringUserInteraction
This moves interactive refactorings from using inheritance to deal with the interaction to composition. Consequently, the interaction can be reused elsewhere.
Configuration menu - View commit details
-
Copy full SHA for b9e6e70 - Browse repository at this point
Copy the full SHA b9e6e70View commit details -
Introduce CodeExplorerMoveToFolderCommand
This combines MoveToFolder and MoveFolder, selecting based on the selected node of the CE. In principle, the backing refactoring actions are capable of dealing with multiple nodes at once. However, the CE only allows selecting single items at the moment and the command reflects that when deriving the models to pass to the refactoring actions.
Configuration menu - View commit details
-
Copy full SHA for 8cde475 - Browse repository at this point
Copy the full SHA 8cde475View commit details
Commits on Mar 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 6b77f0a - Browse repository at this point
Copy the full SHA 6b77f0aView commit details -
Stop moving components into folders they are already in
The exception is moving into the project folder. This simply adds the explicit folder annotation.
Configuration menu - View commit details
-
Copy full SHA for 9b2fc3b - Browse repository at this point
Copy the full SHA 9b2fc3bView commit details
Commits on Mar 24, 2020
-
Merge branch 'next' into MoveToFolderRefactoring
# Conflicts: # Rubberduck.Resources/RubberduckUI.resx
Configuration menu - View commit details
-
Copy full SHA for 16dad99 - Browse repository at this point
Copy the full SHA 16dad99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68c9f55 - Browse repository at this point
Copy the full SHA 68c9f55View commit details
Commits on Mar 29, 2020
-
Only report Let or Set in WriteOnlyPropertyInspection
A test was there, but the assert was wrong.
Configuration menu - View commit details
-
Copy full SHA for ff1c5f6 - Browse repository at this point
Copy the full SHA ff1c5f6View commit details -
Unregister load event handlers in view code behinds
This is done in Rename-, MoveMultipleToFolder- and Move MultipleFoldersView. Also addresses one more review comment to PR rubberduck-vba#5438.
Configuration menu - View commit details
-
Copy full SHA for 6f0a1d7 - Browse repository at this point
Copy the full SHA 6f0a1d7View commit details