Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Folder Refactoring #5438

Merged
merged 13 commits into from
Mar 31, 2020

Commits on Mar 20, 2020

  1. Add MoveToFolderRefactoring

    Also correctly converts folder annotation arguments to the string content and back. This also removes the parentheses around folders.
    MDoerner committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    8a992ee View commit details
    Browse the repository at this point in the history
  2. Fix WriteOnlyPropertyInspection

    It did not consider that there could be a getter in another module with the same name.
    MDoerner committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    213822f View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2020

  1. Add MoveContainingFolderRefactoring

    It moves the containing folder into another folder.
    
    Also fixes ToVbaStringLiteral. (It was missing the surrounding quotes.)
    MDoerner committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    7b2b173 View commit details
    Browse the repository at this point in the history
  2. Add tests for MoveToFolderRefactoring itself

    Also adds members to get the initial model to InteractiveRefactoringTestsBase.
    MDoerner committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    50299d8 View commit details
    Browse the repository at this point in the history
  3. Add tests for MoveContainingFolderRefactoring itself

    There are already tests for the involved refactoring actions.
    MDoerner committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    f17b1f7 View commit details
    Browse the repository at this point in the history
  4. Introduce IRefactoringUserInteraction

    This moves interactive refactorings from using inheritance to deal with the interaction to composition. Consequently, the interaction can be reused elsewhere.
    MDoerner committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    b9e6e70 View commit details
    Browse the repository at this point in the history
  5. Introduce CodeExplorerMoveToFolderCommand

    This combines MoveToFolder and MoveFolder, selecting based on the selected node of the CE.
    In principle, the backing refactoring actions are capable of dealing with multiple nodes at once. However, the CE only allows selecting single items at the moment and the command reflects that when deriving the models to pass to the refactoring actions.
    MDoerner committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    8cde475 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2020

  1. Configuration menu
    Copy the full SHA
    6b77f0a View commit details
    Browse the repository at this point in the history
  2. Stop moving components into folders they are already in

    The exception is moving into the project folder. This simply adds the explicit folder annotation.
    MDoerner committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    9b2fc3b View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. Merge branch 'next' into MoveToFolderRefactoring

    # Conflicts:
    #	Rubberduck.Resources/RubberduckUI.resx
    MDoerner committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    16dad99 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    68c9f55 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2020

  1. Only report Let or Set in WriteOnlyPropertyInspection

    A test was there, but the assert was wrong.
    MDoerner committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    ff1c5f6 View commit details
    Browse the repository at this point in the history
  2. Unregister load event handlers in view code behinds

    This is done in Rename-, MoveMultipleToFolder- and Move MultipleFoldersView.
    Also addresses one more review comment to PR rubberduck-vba#5438.
    MDoerner committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    6f0a1d7 View commit details
    Browse the repository at this point in the history