CodeBuilder - Provide 'casing friendly' default property RHS parameter name #5556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposes a single method for generating a default Let\Set RHS property parameter IdentifierName.
Generates a property RHS parameter name based on the value of the property's IdentifierName.
Relocate and reformat the 'value' resource string from Resources.RubberduckUI to Resources.Refactorings.
MDoerner
reviewed
Aug 13, 2020
|
|
||
| public EncapsulateFieldCandidate(Declaration declaration, IValidateVBAIdentifiers identifierValidator) | ||
| public EncapsulateFieldCandidate(Declaration declaration, IValidateVBAIdentifiers identifierValidator, Func<string, string> paramNameBuilder) |
There was a problem hiding this comment.
I am not a fan of shortening parameter and variable names.
However, here it is good-enough as it is.
| @@ -21,6 +21,8 @@ public class EncapsulateFieldTests : InteractiveRefactoringTestBase<IEncapsulate | |||
| { | |||
| private EncapsulateFieldTestSupport Support { get; } = new EncapsulateFieldTestSupport(); | |||
|
|
|||
| private static Func<string, string> Param = EncapsulateFieldTestSupport.ParamNameBuilder; | |||
There was a problem hiding this comment.
I would prefer something like RhsParameterNameBuilder, but it seems good-enough here in the tests.
RubberduckTests/Refactoring/EncapsulateField/EncapsulateFieldTests.cs
Outdated
Show resolved
Hide resolved
RubberduckTests/Refactoring/EncapsulateField/EncapsulateFieldTests.cs
Outdated
Show resolved
Hide resolved
RubberduckTests/Refactoring/EncapsulateField/EncapsulateUsingStateUDTTests.cs
Outdated
Show resolved
Hide resolved
RubberduckTests/Refactoring/EncapsulateField/EncapsulatedUDTFieldTests.cs
Outdated
Show resolved
Hide resolved
Renaming per suggestions. Also, clean-up of commented code and removal of non-required 'using' directives.
|
@MDoerner Thanks for reviewing this PR so it can be included in the next release. I preferred your naming suggestions - so they have been incorporated. All other comments addressed as well. |
MDoerner
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5552.
This PR modifies the default property RHS parameter IdentifierName. The previous default ('value') creates casing issues(#5552). The PR proposes to resolve the issue by using a custom parameter IdentifierName for each generated property of the form "propertyIdentifierValue". (e.g.,
Property Let Foo(ByVal fooValue As Long)).