Fix "Variable is implicitly Variant" quickfix results for array declarations #5647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both DeclareAsExplicitVariant and DeclareAsExplicitType quickfixes now leverage the ImplicitTypeToExplicitRefactoringAction. Removes DeclareAsExplicitVariantQuickFixTests as redundant
Vogel612
approved these changes
Dec 2, 2020
MDoerner
reviewed
Dec 2, 2020
Rubberduck.Refactorings/ImplicitTypeToExplicit/ImplicitTypeToExplicitRefactoringAction.cs
Outdated
Show resolved
Hide resolved
Tests that the QuickFix correctly invokes the supporting RefactoringAction. Tests for various inspection result scenarios reside in the RefactoringActionTests.
Adds guard clause to constrain refactoring action to the finite set of supported types.
|
Thanks for questioning the use of I've also added unit tests for the two quickfixes. They basically test that the quickfix can successfully invoke the refactoring action. All the other various scenarios from the original quickfix were moved to the refactoring action unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5646
PR modifies the
DeclareAsExplicitVariantto leverage theImplicitTypeToExplicitRefactoringActionand removes theDeclareAsExplicitVarianttests as they are now redundant to the tests for the refactoring action.