New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Indent if-then-colon #5929 #6012
Merged
retailcoder
merged 6 commits into
rubberduck-vba:next
from
awb95:dev-5929-Indent_Single_Line_If_then_Colon
Aug 21, 2022
Merged
Fix Indent if-then-colon #5929 #6012
retailcoder
merged 6 commits into
rubberduck-vba:next
from
awb95:dev-5929-Indent_Single_Line_If_then_Colon
Aug 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Build Rubberduck 2.5.2.6113 completed (commit 0c29367d0b by @awb95) |
retailcoder
approved these changes
Aug 20, 2022
retailcoder
requested changes
Aug 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a typo needs fixing
retailcoder
reviewed
Aug 20, 2022
Fix typo Co-authored-by: Mathieu Guindon <retailcoder@gmail.com>
Fix typo Co-authored-by: Mathieu Guindon <retailcoder@gmail.com>
✅ Build Rubberduck 2.5.2.6115 completed (commit 13d0c244f0 by @awb95) |
✅ Build Rubberduck 2.5.2.6116 completed (commit cca992540e by @awb95) |
retailcoder
approved these changes
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5929 .
The 'then'-Statement triggered an Indent even tough the line got continued with ':'.
Edited Test for IfThenElseOnSameLine to contain valid VBA Code and check #5929