Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve OpenGraph information with adjusted HTML export #1

Merged
merged 16 commits into from
Oct 5, 2023

Conversation

lostgeek
Copy link
Contributor

@lostgeek lostgeek commented Sep 26, 2023

image

data/templates/html/rules.js Outdated Show resolved Hide resolved
data/templates/html/rules.js Outdated Show resolved Hide resolved
data/templates/html/rules.js Outdated Show resolved Hide resolved
rules_doc_generator/model/section.py Outdated Show resolved Hide resolved
php/index.php Outdated Show resolved Hide resolved
rules_doc_generator/model/main.py Outdated Show resolved Hide resolved
@rubenpieters
Copy link
Owner

Thanks! looking good so far. I can also do some fix-up of stuff myself, if you want. Like moving the php stuff to templates.

@lostgeek
Copy link
Contributor Author

I've been ill the last days, but I'll look into cleaning up the code over the weekend.

@lostgeek lostgeek changed the title WIP: Serve OpenGraph information with adjusted HTML export Serve OpenGraph information with adjusted HTML export Sep 30, 2023
@lostgeek
Copy link
Contributor Author

lostgeek commented Sep 30, 2023

I think this should be ready now. I have not touched the GitHub workflow and you probably want to add an additional artifact for the php output as well.

@rubenpieters rubenpieters merged commit de0de65 into rubenpieters:main Oct 5, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants