Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort PO.Item comments #15

Closed
wants to merge 1 commit into from
Closed

Conversation

larvanitis
Copy link

The entries within each comment group get sorted alphabetically in toString output.
Flags also get sorted.

Resolves rubenv/angular-gettext#135

The entries within each comment group get sorted alphabetically in `toString` output.
Flags also get sorted.
@rubenv
Copy link
Owner

rubenv commented Dec 1, 2014

Could you add a test case for this? To make sure we don't break this in the future.

@johnyb
Copy link
Collaborator

johnyb commented Dec 1, 2014

Why would you want to do this? This totally breaks multi-line comments (see failing tests)

@rubenv
Copy link
Owner

rubenv commented Dec 1, 2014

This totally breaks multi-line comments (see failing tests)

Those should be kept intact (obviously).

@larvanitis mentioned that it sorts per comment group, looks like that's not the case.

@larvanitis
Copy link
Author

Yes I just noticed. Only references should get sorted. I am working on it.

@johnyb
Copy link
Collaborator

johnyb commented Dec 1, 2014

Ahh, just saw the reference to the original ticket :) IMHO such a use-case should be handled completely in the extraction library. Because at this point, the structure of the data in the comments is known. In the general lib, I guess, it's impossible to decide how the order of the comments should be.

@larvanitis
Copy link
Author

Closing as invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix order of pot reference comments
3 participants