singular form msgstr used together with msgid plural #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For plural form this tool generates this: ```msgid "%d Comment" msgid_plural "%d Comments" msgstr ""``` poedit and probably other editor are going to throw an error because when we use the plural form we should use multiple `msgstr` My change will generate this result: ```msgid "%d Comment" msgid_plural "%d Comments" msgstr[0] "" msgstr[1] ""```
|
It would be great to have a test-case that is failing without your change. This way, we make sure, this won't break in the future. |
|
Also, what happens, if the msgstr already contains some data? In such cases |
|
@pmettraux btw, did you know, you can easily update PR by just (force)-pushing to the branch you started the PR from? No need to close old PR if those need an update. Thanks for you contribution! 🙇 |
|
Actually I was able to do the same thing but from outside the library. So I will close this pull-request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For plural form this tool generates this:
msgid "%d Comment" msgid_plural "%d Comments" msgstr ""poedit and probably other editor are going to throw an error because when we use the plural form we should use multiple
msgstrMy change will generate this result:
msgid "%d Comment" msgid_plural "%d Comments" msgstr[0] "" msgstr[1] ""