Core: fix in ortb -> legacy native asset conversion (prebid#9923)

rubicon-project · Aug 25, 2023 · f2ce5ee · f2ce5ee
1 parent 824e22e
commit f2ce5ee
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 16 deletions.
diff --git a/src/native.js b/src/native.js
@@ -556,6 +556,21 @@ export function toOrtbNativeRequest(legacyNativeAssets) {
   return ortb;
 }
 
+/**
+ * Greatest common divisor between two positive integers
+ * https://en.wikipedia.org/wiki/Euclidean_algorithm
+ */
+function gcd(a, b) {
+  while (a && b && a !== b) {
+    if (a > b) {
+      a = a - b;
+    } else {
+      b = b - a;
+    }
+  }
+  return a || b;
+}
+
 /**
  * This function converts an OpenRTB native request object to Prebid proprietary
  * format. The purpose of this function is to help adapters to handle the
@@ -584,12 +599,13 @@ export function fromOrtbNativeRequest(openRTBRequest) {
       if (asset.img.w && asset.img.h) {
         image.sizes = [asset.img.w, asset.img.h];
       } else if (asset.img.wmin && asset.img.hmin) {
-        image.aspect_ratios = {
+        const scale = gcd(asset.img.wmin, asset.img.hmin)
+        image.aspect_ratios = [{
           min_width: asset.img.wmin,
           min_height: asset.img.hmin,
-          ratio_width: asset.img.wmin,
-          ratio_height: asset.img.hmin
-        }
+          ratio_width: asset.img.wmin / scale,
+          ratio_height: asset.img.hmin / scale
+        }]
       }
 
       if (asset.img.type === NATIVE_IMAGE_TYPES.MAIN) {

diff --git a/test/spec/native_spec.js b/test/spec/native_spec.js
@@ -1002,22 +1002,22 @@ describe('validate native', function () {
 
     expect(oldNativeRequest.image).to.deep.include({
       required: false,
-      aspect_ratios: {
+      aspect_ratios: [{
         min_width: 836,
         min_height: 627,
-        ratio_width: 836,
-        ratio_height: 627
-      }
+        ratio_width: 4,
+        ratio_height: 3
+      }]
     });
 
     expect(oldNativeRequest.icon).to.deep.include({
       required: true,
-      aspect_ratios: {
+      aspect_ratios: [{
         min_width: 50,
         min_height: 50,
-        ratio_width: 50,
-        ratio_height: 50
-      }
+        ratio_width: 1,
+        ratio_height: 1
+      }]
     });
     expect(oldNativeRequest.sponsoredBy).to.include({
       required: true,
@@ -1119,12 +1119,12 @@ describe('validate native', function () {
         },
         icon: {
           required: true,
-          aspect_ratios: {
+          aspect_ratios: [{
             min_width: 50,
             min_height: 50,
-            ratio_width: 50,
-            ratio_height: 50
-          }
+            ratio_width: 1,
+            ratio_height: 1
+          }]
         },
         sponsoredBy: {
           required: true,