Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending TERM does not raise SignalException #1839

Closed
hone opened this issue Jul 27, 2012 · 0 comments
Closed

Sending TERM does not raise SignalException #1839

hone opened this issue Jul 27, 2012 · 0 comments

Comments

@hone
Copy link

hone commented Jul 27, 2012

I'm running on rbx 2.0.0dev from today on 64-bit ubuntu 12.04. I'm working on better signal handling in resque here. The tests are failing for me on Travis. I debugged some more locally and made a smaller repro case. In rbx it bails out fairly quickly not really obeying the timings.

$ time PATH=$PATH:/usr/local/rubinius/2.0.0dev/bin /usr/local/bin/rbx/rbx worker.rb
FAILURE

real    0m2.266s
user    0m0.228s
sys     0m0.032s

vs MRI 1.9.3-p194

$ time ruby worker.rb
SUCCESS!

real    0m12.031s
user    0m0.016s
sys     0m0.012s
Gibheer pushed a commit to Gibheer/rubinius that referenced this issue Aug 14, 2012
@dbussink @Gibheer
Setup proper SignalException handling
633907a 
What a wonderful MRI behavior we see here again. What MRI does is when a
SignalException escapes to the toplevel, it catches it, sets up the
default signal handler for that signal and reraises the signal to the
current process. We therefore mimic this behavior by setting up signal
handlers for the same signals MRI catches and raises an exception. Our
post handling then does the same by setting up the default handler and
resending the signal.

Fixes rubinius#1839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbussink @hone