Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a proper comma addition #37

Merged
merged 1 commit into from
Jun 12, 2012
Merged

a proper comma addition #37

merged 1 commit into from
Jun 12, 2012

Conversation

agis
Copy link
Contributor

@agis agis commented Apr 28, 2012

No description provided.

@phiggins
Copy link
Contributor

To give my unsolicited opinion, that sentence should probably be something like:

When a named scope defined with a lambda and parameters becomes too complicated it is preferable to make a class method which returns an ActiveRecord::Relation object instead.

bbatsov added a commit that referenced this pull request Jun 12, 2012
a proper comma addition
@bbatsov bbatsov merged commit bf5a334 into rubocop:master Jun 12, 2012
JuanitoFatas added a commit to ruby-china/rails-style-guide that referenced this pull request Jun 12, 2012
尊敬的提交审阅者  你好,

37 号 Pull Request 修补了一个多馀的逗号(英文)

38 号 Pull Request 修补了一个错误(简体繁体)。

你谦卑的仆人,

台北小码农 Juanito Fatas Huang 于台北 <katehuang0320@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants