Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macro? #120

Merged
merged 1 commit into from Sep 25, 2020
Merged

Fix macro? #120

merged 1 commit into from Sep 25, 2020

Conversation

@marcandre
Copy link
Contributor

@marcandre marcandre commented Sep 24, 2020

This PR fixes rubocop-hq/rubocop#8765

There were many issues with how macro_scope?:

  • recursion was badly written, so many cases were not handled well
  • if did not distinguish if in the conditions part or on of the bodies

It also introduces Node#parent?

Builds on #119

I'll do a final review when I'm less sleepy 馃槄

@marcandre marcandre force-pushed the marcandre:fix_macro_p branch 3 times, most recently from b434fb8 to 39a0929 Sep 24, 2020
@marcandre
Copy link
Contributor Author

@marcandre marcandre commented Sep 24, 2020

@marcandre marcandre force-pushed the marcandre:fix_macro_p branch 3 times, most recently from d067ec9 to 1607269 Sep 24, 2020
Bump minimum compatibility with main gem.
@marcandre marcandre force-pushed the marcandre:fix_macro_p branch from 1607269 to e31b2a7 Sep 25, 2020
@marcandre marcandre merged commit 0ee773e into rubocop-hq:master Sep 25, 2020
16 checks passed
16 checks passed
Specs | RuboCop: master | 2.4 (ubuntu)
Details
Specs | RuboCop: master | 2.5 (ubuntu)
Details
Specs | RuboCop: master | 2.6 (ubuntu)
Details
Specs | RuboCop: master | 2.7 (ubuntu)
Details
Specs | RuboCop: master | head (ubuntu)
Details
Specs | RuboCop: master | mingw (windows)
Details
Specs | RuboCop: 0.92.0 | 2.4 (ubuntu)
Details
Specs | RuboCop: 0.92.0 | head (ubuntu)
Details
Coverage | RuboCop: 0.92.0 | 2.4 (ubuntu)
Details
Specs "modern" | RuboCop: master | 2.7 (ubuntu)
Details
Coding Style | RuboCop: master | 2.7 (ubuntu)
Details
Main Gem Specs | RuboCop: 0.92.0 | 2.4 (ubuntu)
Details
Main Gem Specs | RuboCop: master | 2.4 (ubuntu)
Details
Main Gem Specs | RuboCop: 0.92.0 | 2.7 (ubuntu)
Details
Main Gem Specs | RuboCop: master | 2.7 (ubuntu)
Details
Summary 2 potential rules
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can鈥檛 perform that action at this time.