Extract capybara #1

pirj · 2022-12-18T12:43:10Z

No description provided.

.github/CONTRIBUTING.md

pirj

Self-review

Rakefile

pirj · 2022-12-20T21:25:05Z

bin/build_config

 YARD::Tags::Library.define_tag('Cop Safety Information', :safety)
-YARD.parse(Dir[glob].prepend(rspec_cop_path), [])


We may need to get this back if we introduce a base class.

lib/rubocop-capybara.rb

lib/rubocop/capybara.rb

lib/rubocop/capybara/version.rb

pirj · 2022-12-20T21:34:25Z

rubocop-capybara.gemspec

-    'git@nilsgemeinhardt.de'
-  ]
+  spec.homepage = 'https://github.com/rubocop/rubocop-capybara'
+  spec.authors = ['foo'] # TODO


Speaking about authors, @ydah you seem to have added more than a half of cops.

If you need an email address, use the following
t.yudai92@gmail.com

rubocop-capybara.gemspec

ydah · 2022-12-21T06:25:29Z

[ask] Should we move it to https://github.com/rubocop/rubocop-capybara?

.rubocop.yml

ydah · 2022-12-21T06:34:45Z

CHANGELOG.md

- Gem is no longer 20MB (sorry!). ([@nevir])
- `RspecFileName` cop allows for method specs to organized into directories by class and type. ([@nevir])
-
-## 1.0.rc1



Unnecessary line breaks are likely here.

pirj · 2022-12-21T06:37:47Z

move it to https://github.com/rubocop/rubocop-capybara?

I'd love to move the final result there. With only history related to files currently in the repository, without the noise about all past unrelated RSpec cop changes.

I still have one idea left - to let git-filter-repo handle the renames. I'll give it a shot soon.

But this PR still stands, as it has all the needed changes, and the resulting file structure and contents are the same.

ydah · 2022-12-21T07:16:18Z

lib/rubocop/cop/capybara/current_path_expectation.rb

+        # @!method as_is_matcher(node)
+        def_node_matcher :as_is_matcher, <<-PATTERN
+          (send
+            #expectation_set_on_current_path ${:to :to_not :not_to}


Perhaps, but it seems that there are still remnants of RuboCop RSpec here. I think ${:to :to_not :not_to} is a peculiar RSpec expression.

But we believe this can be followed up later.

I see those options:

keep this cop in rubocop-rspec, since it's specific to RSpec

keep this cop here, since it's specific to Capybara

extract to rubocop-rspec-capybara or rubocop-capybara-rspec

keep this cop here, but move it to Capybara/RSpec sub-department

What is your take on this?

keep this cop here, since it's specific to Capybara

keep this cop here, but move it to Capybara/RSpec sub-department

These opinions seem to be good to me.

Would it be good to have a sub-department for each where Expectation is involved 🤔.
There may be unintended side effects if one tries to handle it in one cop. But I haven't found a specific problem yet.

ydah

Looks good! Thanks for the great work 🚀

pirj · 2022-12-22T19:32:11Z

I've figured out a reliable and more or less simple method to keep the history for a limited number of files in the repo:

git clone --no-local rubocop-rspec rubocop-capybara-hist
cd rubocop-capybara-hist
git-filter-repo $( (cat ../rubocop-capybara/rename | xargs -I_ echo '--path-rename _ ') )
git-filter-repo $( (cd ../rubocop-capybara && git ls-files) | xargs -I_ echo '--path _ ')
git remote add origin git@github.com:rubocop/rubocop-capybara.git
git push --set-upstream origin master
git checkout -b capybara-only
cd ../rubocop-capybara
cp -r * ../rubocop-capybara-hist
cp -r $( git ls-files | grep '^\.' | grep -v '\.github' ) ../rubocop-capybara-hist
cp -r .github ../rubocop-capybara-hist
cd -
git commit --all --message 'RSpec -> Capybara'
rvm use --create 3.0.4@rubocop-capybara
bundle
rake
git push origin capybara-only
hub pull-request --assign pirj

rename:

docs/modules/ROOT/pages/cops_rspec_capybara.adoc:docs/modules/ROOT/pages/cops_capybara.adoc
docs/modules/ROOT/pages/development.adoc:docs/modules/ROOT/pages/development.adoc
docs/modules/ROOT/pages/index.adoc:docs/modules/ROOT/pages/index.adoc
docs/modules/ROOT/pages/installation.adoc:docs/modules/ROOT/pages/installation.adoc
docs/modules/ROOT/pages/usage.adoc:docs/modules/ROOT/pages/usage.adoc
lib/rubocop/rspec/config_formatter.rb:lib/rubocop/capybara/config_formatter.rb
lib/rubocop/rspec/description_extractor.rb:lib/rubocop/capybara/description_extractor.rb
lib/rubocop/rspec/version.rb:lib/rubocop/capybara/version.rb
lib/rubocop/cop/rspec/mixin/capybara_help.rb:lib/rubocop/cop/capybara/mixin/capybara_help.rb
lib/rubocop/cop/rspec/mixin/css_selector.rb:lib/rubocop/cop/capybara/mixin/css_selector.rb
lib/rubocop/cop/rspec/capybara/current_path_expectation.rb:lib/rubocop/cop/capybara/current_path_expectation.rb
lib/rubocop/cop/rspec/capybara/match_style.rb:lib/rubocop/cop/capybara/match_style.rb
lib/rubocop/cop/rspec/capybara/negation_matcher.rb:lib/rubocop/cop/capybara/negation_matcher.rb
lib/rubocop/cop/rspec/capybara/specific_actions.rb:lib/rubocop/cop/capybara/specific_actions.rb
lib/rubocop/cop/rspec/capybara/specific_finders.rb:lib/rubocop/cop/capybara/specific_finders.rb
lib/rubocop/cop/rspec/capybara/specific_matcher.rb:lib/rubocop/cop/capybara/specific_matcher.rb
lib/rubocop/cop/rspec/capybara/visibility_matcher.rb:lib/rubocop/cop/capybara/visibility_matcher.rb
lib/rubocop/cop/rspec_cops.rb:lib/rubocop/cop/capybara_cops.rb
lib/rubocop-rspec.rb:lib/rubocop-capybara.rb
rubocop-rspec.gemspec:rubocop-capybara.gemspec
spec/project/changelog_spec.rb:spec/project/changelog_spec.rb
spec/project/default_config_spec.rb:spec/project/default_config_spec.rb
spec/rubocop/rspec/config_formatter_spec.rb:spec/rubocop/capybara/config_formatter_spec.rb
spec/rubocop/rspec/description_extractor_spec.rb:spec/rubocop/capybara/description_extractor_spec.rb
spec/rubocop/cop/rspec/capybara/current_path_expectation_spec.rb:spec/rubocop/cop/capybara/current_path_expectation_spec.rb
spec/rubocop/cop/rspec/capybara/match_style_spec.rb:spec/rubocop/cop/capybara/match_style_spec.rb
spec/rubocop/cop/rspec/capybara/negation_matcher_spec.rb:spec/rubocop/cop/capybara/negation_matcher_spec.rb
spec/rubocop/cop/rspec/capybara/specific_actions_spec.rb:spec/rubocop/cop/capybara/specific_actions_spec.rb
spec/rubocop/cop/rspec/capybara/specific_finders_spec.rb:spec/rubocop/cop/capybara/specific_finders_spec.rb
spec/rubocop/cop/rspec/capybara/specific_matcher_spec.rb:spec/rubocop/cop/capybara/specific_matcher_spec.rb
spec/rubocop/cop/rspec/capybara/visibility_matcher_spec.rb:spec/rubocop/cop/capybara/visibility_matcher_spec.rb

I intend to:

push master and a branch with an identical PR to rubocop/rubocop-capybara as soon as I have proper permissions to push there
publish the gem, and share publish rights with @bquorning, @Darhazer and @ydah
ask someone who has permissions to remove/archive this repo

Does it sound like a plan?

bquorning

Great work @pirj ❤️

Just to double check, the removal of FeatureMethods is intentional, right?

bquorning · 2022-12-22T22:14:31Z

.rubocop.yml

@@ -112,7 +110,7 @@ Layout/LineEndStringConcatenationIndentation:
 Style/EmptyHeredoc:
  Enabled: true

-# Enable our own pending cops.
+# Enable pending rubocop-rspec cops.


The .github/PULL_REQUEST_TEMPLATE.md says “[ ] The cop is configured as Enabled: true in .rubocop.yml.” That should probably be removed, as it only applies to RSpec cops.

Good catch 👍

… conf

pirj · 2022-12-23T18:05:21Z

Just to double check, the removal of FeatureMethods is intentional, right?

@bquorning yes, I kept the cop in rubocop-rspec rather than inheriting from rubocop-capybara like other extracted cops in the extraction PR](rubocop/rubocop-rspec#1519). I feel that this cop is RSpec-specific, and we'd better keep it.

ydah · 2022-12-27T01:22:29Z

[ask] It looks like the following also needs to be corrected, what do you think?

rubocop-capybara/MIT-LICENSE.md

Line 3 in 495e175

pirj · 2022-12-29T21:02:37Z

No longer needed, even for history purposes.

pirj force-pushed the extract-capybara branch from 4c80678 to 885e5d9 Compare December 18, 2022 12:49

pirj mentioned this pull request Dec 18, 2022

Extract Capybara cops rubocop/rubocop-rspec#1519

Merged

5 tasks

Remove irrelevant files; move/rename relevant

56d4d66

pirj force-pushed the extract-capybara branch 2 times, most recently from 2291a6d to ffa14ee Compare December 18, 2022 13:04

Make content changes

2f80e6d

pirj force-pushed the extract-capybara branch from ffa14ee to 2f80e6d Compare December 18, 2022 13:06

ydah reviewed Dec 19, 2022

View reviewed changes

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved

pirj commented Dec 20, 2022

View reviewed changes

ydah reviewed Dec 21, 2022

View reviewed changes

.rubocop.yml Show resolved Hide resolved

ydah reviewed Dec 21, 2022

View reviewed changes

pirj added 7 commits December 21, 2022 11:13

fixup! code review, mdformat: remove extra empty line

697cf88

fixup! Remove optional email gemspec attr

65c37c7

fixup! Set Yudai as a primary author

94f23d2

fixup! Align the version number with rubocop-rspec

fe2987c

fixup! Use the new way to inject defaults

020923f

fixup! Some build task simplifications

5d4ec91

fixup! Revert sudden removal of mdformat/codespell/yamllint docs

62ace18

pirj requested a review from ydah December 21, 2022 09:30

ydah approved these changes Dec 21, 2022

View reviewed changes

pirj added 2 commits December 22, 2022 13:32

fixup! Fix badge link

7ecfa8e

fixup! Replace mentions of RSpec where it should be capybara

54cc664

bquorning approved these changes Dec 22, 2022

View reviewed changes

pirj added 2 commits December 23, 2022 20:50

fixup! Fix build_config message

67e8c15

fixup! code review: remove the requirement to add new cops to rubocop…

2e3f10f

… conf

pirj closed this Dec 29, 2022

pirj deleted the extract-capybara branch December 29, 2022 21:02

ydah mentioned this pull request Feb 16, 2023

Extract Factory Bot cops ydah/rubocop-factory_bot#1

Closed

ydah mentioned this pull request Apr 13, 2023

Extract RuboCop FactoryBot from RuboCop RSpec rubocop/rubocop-factory_bot#1

Merged

6 tasks

pirj mentioned this pull request Mar 10, 2024

Extract RSpec Rails cops ydah/rubocop-rspec_rails#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extract capybara #1

Extract capybara #1

pirj commented Dec 18, 2022

pirj left a comment

pirj Dec 20, 2022

pirj Dec 20, 2022

ydah Dec 27, 2022

ydah commented Dec 21, 2022 •

edited

ydah Dec 21, 2022

pirj commented Dec 21, 2022

ydah Dec 21, 2022 •

edited

pirj Dec 21, 2022

ydah Dec 21, 2022 •

edited

ydah left a comment

pirj commented Dec 22, 2022

bquorning left a comment

bquorning Dec 22, 2022

pirj Dec 23, 2022

pirj commented Dec 23, 2022

ydah commented Dec 27, 2022

pirj commented Dec 29, 2022

		YARD::Tags::Library.define_tag('Cop Safety Information', :safety)
		YARD.parse(Dir[glob].prepend(rspec_cop_path), [])

Extract capybara #1

Extract capybara #1

Conversation

pirj commented Dec 18, 2022

pirj left a comment

Choose a reason for hiding this comment

pirj Dec 20, 2022

Choose a reason for hiding this comment

pirj Dec 20, 2022

Choose a reason for hiding this comment

ydah Dec 27, 2022

Choose a reason for hiding this comment

ydah commented Dec 21, 2022 • edited

ydah Dec 21, 2022

Choose a reason for hiding this comment

pirj commented Dec 21, 2022

ydah Dec 21, 2022 • edited

Choose a reason for hiding this comment

pirj Dec 21, 2022

Choose a reason for hiding this comment

ydah Dec 21, 2022 • edited

Choose a reason for hiding this comment

ydah left a comment

Choose a reason for hiding this comment

pirj commented Dec 22, 2022

bquorning left a comment

Choose a reason for hiding this comment

bquorning Dec 22, 2022

Choose a reason for hiding this comment

pirj Dec 23, 2022

Choose a reason for hiding this comment

pirj commented Dec 23, 2022

ydah commented Dec 27, 2022

pirj commented Dec 29, 2022

ydah commented Dec 21, 2022 •

edited

ydah Dec 21, 2022 •

edited

ydah Dec 21, 2022 •

edited