Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that excluded files in rubocop-rails did not work #187

Merged
merged 1 commit into from Jan 24, 2020

Conversation

@sinsoku
Copy link
Contributor

sinsoku commented Jan 11, 2020

bin/* and db/schema.rb were not excluded.
Exclude files should be absolute paths internally, so it fixes to call the make_excludes_absolute method.

Ref: rubocop-hq/rubocop@cb63798


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
@sinsoku sinsoku force-pushed the sinsoku:make_excludes_absolute branch from adb09a7 to 788d153 Jan 11, 2020
@pocke

This comment has been minimized.

Copy link
Member

pocke commented Jan 12, 2020

I guess it is not a rubocop-rails specific problem. So I will apply this change to also rubocop-extension-generator.

And I've confirmed that other plugins do not have Excludes in AllCops section.
https://github.com/search?l=YAML&q=user%3Arubocop-hq+Exclude&type=Code

@sinsoku sinsoku force-pushed the sinsoku:make_excludes_absolute branch from 788d153 to ce5ecf7 Jan 14, 2020
@sinsoku sinsoku changed the title Fix the issue that excluded files in rspec-rails did not work Fix the issue that excluded files in rubocop-rails did not work Jan 14, 2020
@sinsoku sinsoku force-pushed the sinsoku:make_excludes_absolute branch from ce5ecf7 to aa3ab45 Jan 14, 2020
CHANGELOG.md Outdated Show resolved Hide resolved
@sinsoku sinsoku force-pushed the sinsoku:make_excludes_absolute branch from aa3ab45 to 9d88d1f Jan 20, 2020
`bin/*` and `db/schema.rb` were not excluded.
Exclude files should be absolute paths internally, so it fixes to call the `make_excludes_absolute` method.

Ref: rubocop-hq/rubocop@cb63798
@sinsoku sinsoku force-pushed the sinsoku:make_excludes_absolute branch from 9d88d1f to 61b7567 Jan 20, 2020
@koic koic merged commit fa74f7c into rubocop-hq:master Jan 24, 2020
7 checks passed
7 checks passed
ci/circleci: JRuby 9.2 Your tests passed on CircleCI!
Details
ci/circleci: Ruby 2.3 Your tests passed on CircleCI!
Details
ci/circleci: Ruby 2.4 Your tests passed on CircleCI!
Details
ci/circleci: Ruby 2.5 Your tests passed on CircleCI!
Details
ci/circleci: Ruby 2.6 Your tests passed on CircleCI!
Details
ci/circleci: Ruby 2.7 Your tests passed on CircleCI!
Details
ci/circleci: Ruby HEAD Your tests passed on CircleCI!
Details
@koic

This comment has been minimized.

Copy link
Member

koic commented Jan 24, 2020

Thanks!

@sinsoku sinsoku deleted the sinsoku:make_excludes_absolute branch Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.