Add ContextMethod cop #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
force-pushed
the
417_context_method
branch
from
f2f79b0
to
dcda0e8
Compare
|
@bquorning @Darhazer @dgollahon Is there anything that needs to be addressed here? |
bquorning
reviewed
Aug 18, 2019
bquorning
approved these changes
Aug 18, 2019
Resolves rubocop#417 Fixes rubocop#751 Supersedes rubocop#751
pirj
force-pushed
the
417_context_method
branch
from
3cd4a80
to
6d4d9d9
Compare
|
@bquorning Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #417 is would be good to have a cop to check for the combination of context and a method name.
Based on #751, addressed code review notes.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).