-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
5 changed files
with
252 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,247 @@ | ||
### New features | ||
|
||
* [#2956](https://github.com/bbatsov/rubocop/issues/2956): Prefer `.ruby-version` to `TargetRubyVersion`. ([@pclalv][]) | ||
* [#3095](https://github.com/bbatsov/rubocop/issues/3095): Add `IndentationWidth` configuration parameter for `Style/AlignParameters` cop. ([@alexdowad][]) | ||
* [#3066](https://github.com/bbatsov/rubocop/issues/3066): Add new `Style/ImplicitRuntimeError` cop which advises the use of an explicit exception class when raising an error. ([@alexdowad][]) | ||
* [#3018](https://github.com/bbatsov/rubocop/issues/3018): Add new `Style/EachForSimpleLoop` cop which advises the use of `Integer#times` for simple loops which iterate a fixed number of times. ([@alexdowad][]) | ||
* [#2595](https://github.com/bbatsov/rubocop/issues/2595): New `compact` style for `Style/SpaceInsideLiteralHashBraces`. ([@alexdowad][]) | ||
* [#2927](https://github.com/bbatsov/rubocop/issues/2927): Add autocorrect for `Rails/Validation` cop. ([@neodelf][]) | ||
* [#3135](https://github.com/bbatsov/rubocop/pull/3135): Add new `Rails/OutputSafety` cop. ([@josh][]) | ||
* [#3164](https://github.com/bbatsov/rubocop/pull/3164): Add [Fastlane](https://fastlane.tools/)'s Fastfile to the default Includes. ([@jules2689][]) | ||
* [#3173](https://github.com/bbatsov/rubocop/pull/3173): Make `Style/ModuleFunction` configurable with `module_function` and `extend_self` styles. ([@tjwp][]) | ||
* [#3105](https://github.com/bbatsov/rubocop/issues/3105): Add new `Rails/RequestReferer` cop. ([@giannileggio][]) | ||
* [#3200](https://github.com/bbatsov/rubocop/pull/3200): Add autocorrect for `Style/EachForSimpleLoop` cop. ([@tejasbubane][]) | ||
* [#3058](https://github.com/bbatsov/rubocop/issues/3058): Add new `Style/SpaceInsideArrayPercentLiteral` cop. ([@owst][]) | ||
* [#3058](https://github.com/bbatsov/rubocop/issues/3058): Add new `Style/SpaceInsidePercentLiteralDelimiters` cop. ([@owst][]) | ||
* [#3179](https://github.com/bbatsov/rubocop/pull/3179): Expose files to support testings Cops using RSpec. ([@tjwp][]) | ||
* [#3191](https://github.com/bbatsov/rubocop/issues/3191): Allow arbitrary comments after cop names in CommentConfig lines (e.g. rubocop:enable). ([@owst][]) | ||
* [#3165](https://github.com/bbatsov/rubocop/pull/3165): Add new `Lint/PercentStringArray` cop. ([@owst][]) | ||
* [#3165](https://github.com/bbatsov/rubocop/pull/3165): Add new `Lint/PercentSymbolArray` cop. ([@owst][]) | ||
* [#3177](https://github.com/bbatsov/rubocop/pull/3177): Add new `Style/NumericLiteralPrefix` cop. ([@tejasbubane][]) | ||
* [#1646](https://github.com/bbatsov/rubocop/issues/1646): Add configuration style `indented_relative_to_receiver` for `Style/MultilineMethodCallIndentation`. ([@jonas054][]) | ||
* New cop `Lint/ShadowedException` checks for the order which exceptions are rescued to avoid rescueing a less specific exception before a more specific exception. ([@rrosenblum][]) | ||
* [#3127](https://github.com/bbatsov/rubocop/pull/3127): New cop `Lint/InheritException` checks for error classes inheriting from `Exception`, and instead suggests `RuntimeError` or `StandardError`. ([@drenmi][]) | ||
* Add new `Performance/PushSplat` cop. ([@segiddins][]) | ||
* [#3089](https://github.com/bbatsov/rubocop/issues/3089): Add new `Rails/Exit` cop. ([@sgringwe][]) | ||
|
||
### Bug fixes | ||
|
||
* [#3005](https://github.com/bbatsov/rubocop/issues/3005): Symlink protection prevents use of caching in CI context. ([@urbanautomaton][]) | ||
* [#3037](https://github.com/bbatsov/rubocop/issues/3037): `Style/StringLiterals` understands that a bare '#', not '#@variable' or '#{interpolation}', does not require double quotes. ([@alexdowad][]) | ||
* [#2722](https://github.com/bbatsov/rubocop/issues/2722): `Style/ExtraSpacing` does not attempt to align an equals sign in an argument list with one in an assignment statement. ([@alexdowad][]) | ||
* [#3133](https://github.com/bbatsov/rubocop/issues/3133): `Style/MultilineMethodCallBraceLayout` does not register offenses for single-line calls. ([@alexdowad][]) | ||
* [#3170](https://github.com/bbatsov/rubocop/issues/3170): `Style/MutableConstant` does not infinite-loop when correcting an array with no brackets. ([@alexdowad][]) | ||
* [#3150](https://github.com/bbatsov/rubocop/issues/3150): Fix auto-correct for Style/MultilineArrayBraceLayout. ([@jspanjers][]) | ||
* [#3192](https://github.com/bbatsov/rubocop/pull/3192): Fix `Lint/UnusedBlockArgument`'s `IgnoreEmptyBlocks` parameter from being removed from configuration. ([@jfelchner][]) | ||
* [#3114](https://github.com/bbatsov/rubocop/issues/3114): Fix alignment `end` when auto-correcting `Style/EmptyElse`. ([@rrosenblum][]) | ||
* [#3120](https://github.com/bbatsov/rubocop/issues/3120): Fix `Lint/UselessAccessModifier` reporting useless access modifiers inside {Class,Module,Struct}.new blocks. ([@owst][]) | ||
* [#3125](https://github.com/bbatsov/rubocop/issues/3125): Fix `Rails/UniqBeforePluck` to ignore `uniq` with block. ([@tejasbubane][]) | ||
* [#3116](https://github.com/bbatsov/rubocop/issues/3116): `Style/SpaceAroundKeyword` allows `&.` method calls after `super` and `yield`. ([@segiddins][]) | ||
* [#3131](https://github.com/bbatsov/rubocop/issues/3131): Fix `Style/ZeroLengthPredicate` to ignore `size` and `length` variables. ([@tejasbubane][]) | ||
* [#3146](https://github.com/bbatsov/rubocop/pull/3146): Fix `NegatedIf` and `NegatedWhile` to ignore double negations. ([@natalzia-paperless][]) | ||
* [#3140](https://github.com/bbatsov/rubocop/pull/3140): `Style/FrozenStringLiteralComment` works with file doesn't have any tokens. ([@pocke][]) | ||
* [#3154](https://github.com/bbatsov/rubocop/issues/3154): Fix handling of `()` in `Style/RedundantParentheses`. ([@lumeet][]) | ||
* [#3155](https://github.com/bbatsov/rubocop/issues/3155): Fix `Style/SpaceAfterNot` reporting on the `not` keyword. ([@NobodysNightmare][]) | ||
* [#3160](https://github.com/bbatsov/rubocop/pull/3160): `Style/Lambda` fix whitespacing when auto-correcting unparenthesized arguments. ([@palkan][]) | ||
* [#2944](https://github.com/bbatsov/rubocop/issues/2944): Don't crash on strings that span multiple lines but only have one pair of delimiters in `Style/StringLiterals`. ([@jonas054][]) | ||
* [#3157](https://github.com/bbatsov/rubocop/issues/3157): Don't let `LineEndConcatenation` and `UnneededInterpolation` make changes to the same string during auto-correct. ([@jonas054][]) | ||
* [#3187](https://github.com/bbatsov/rubocop/issues/3187): Let `Style/BlockDelimiters` ignore blocks in *all* method arguments. ([@jonas054][]) | ||
* Modify `Style/ParallelAssignment` to use implicit begins when parallel assignment uses a `rescue` modifier and is the only thing in the method. ([@rrosenblum][]) | ||
* [#3217](https://github.com/bbatsov/rubocop/pull/3217): Fix output of ellipses for multi-line offense ranges in HTML formatter. ([@jonas054][]) | ||
* [#3207](https://github.com/bbatsov/rubocop/issues/3207): Auto-correct modifier `while`/`until` and `begin`..`end` + `while`/`until` in `Style/InfiniteLoop`. ([@jonas054][]) | ||
* [#3202](https://github.com/bbatsov/rubocop/issues/3202): Fix `Style/EmptyElse` registering wrong offenses and thus making RuboCop crash. ([@deivid-rodriguez][]) | ||
* [#3183](https://github.com/bbatsov/rubocop/issues/3183): Ensure `Style/SpaceInsideBlockBraces` reports offenses for multi-line blocks. ([@owst][]) | ||
* [#3017](https://github.com/bbatsov/rubocop/issues/3017): Fix `Style/StringLiterals` to register offenses on non-ascii strings. ([@deivid-rodriguez][]) | ||
* [#3056](https://github.com/bbatsov/rubocop/issues/3056): Fix `Style/StringLiterals` to register offenses on non-ascii strings. ([@deivid-rodriguez][]) | ||
* [#2986](https://github.com/bbatsov/rubocop/issues/2986): Fix `RedundantBlockCall` to not report calls that pass block arguments, or where the block has been overridden. ([@owst][]) | ||
* [#3223](https://github.com/bbatsov/rubocop/issues/3223): Return can take many arguments. ([@ptarjan][]) | ||
* [#3239](https://github.com/bbatsov/rubocop/pull/3239): Fix bug with --auto-gen-config and a file that does not exist. ([@meganemura][]) | ||
* [#3138](https://github.com/bbatsov/rubocop/issues/3138): Fix RuboCop crashing when config file contains utf-8 characters and external encoding is not utf-8. ([@deivid-rodriguez][]) | ||
* [#3175](https://github.com/bbatsov/rubocop/pull/3175): Generate 'Exclude' list for the cops with configurable enforced style to `.rubocop_todo.yml` if different styles are used. ([@flexoid][]) | ||
* [#3231](https://github.com/bbatsov/rubocop/pull/3231): Make `Rails/UniqBeforePluck` more conservative. ([@tjwp][]) | ||
|
||
### Changes | ||
|
||
* [#3149](https://github.com/bbatsov/rubocop/pull/3149): Make `Style/HashSyntax` configurable to not report hash rocket syntax for symbols ending with ? or ! when using ruby19 style. ([@owst][]) | ||
* [#1758](https://github.com/bbatsov/rubocop/issues/1758): Let `Style/ClosingParenthesisIndentation` follow `Style/AlignParameters` configuration for method calls. ([@jonas054][]) | ||
* [#3224](https://github.com/bbatsov/rubocop/issues/3224): Rename `Style/DeprecatedHashMethods` to `Style/PreferredHashMethods`. ([@tejasbubane][]) | ||
|
||
[@bbatsov]: https://github.com/bbatsov | ||
[@jonas054]: https://github.com/jonas054 | ||
[@yujinakayama]: https://github.com/yujinakayama | ||
[@dblock]: https://github.com/dblock | ||
[@nevir]: https://github.com/nevir | ||
[@daviddavis]: https://github.com/daviddavis | ||
[@sds]: https://github.com/sds | ||
[@fancyremarker]: https://github.com/fancyremarker | ||
[@sinisterchipmunk]: https://github.com/sinisterchipmunk | ||
[@vonTronje]: https://github.com/vonTronje | ||
[@agrimm]: https://github.com/agrimm | ||
[@pmenglund]: https://github.com/pmenglund | ||
[@chulkilee]: https://github.com/chulkilee | ||
[@codez]: https://github.com/codez | ||
[@emou]: https://github.com/emou | ||
[@skanev]: http://github.com/skanev | ||
[@claco]: http://github.com/claco | ||
[@rifraf]: http://github.com/rifraf | ||
[@scottmatthewman]: https://github.com/scottmatthewman | ||
[@ma2gedev]: http://github.com/ma2gedev | ||
[@jeremyolliver]: https://github.com/jeremyolliver | ||
[@hannestyden]: https://github.com/hannestyden | ||
[@geniou]: https://github.com/geniou | ||
[@jkogara]: https://github.com/jkogara | ||
[@tmorris-fiksu]: https://github.com/tmorris-fiksu | ||
[@mockdeep]: https://github.com/mockdeep | ||
[@hiroponz]: https://github.com/hiroponz | ||
[@tamird]: https://github.com/tamird | ||
[@fshowalter]: https://github.com/fshowalter | ||
[@cschramm]: https://github.com/cschramm | ||
[@bquorning]: https://github.com/bquorning | ||
[@bcobb]: https://github.com/bcobb | ||
[@irrationalfab]: https://github.com/irrationalfab | ||
[@tommeier]: https://github.com/tommeier | ||
[@sfeldon]: https://github.com/sfeldon | ||
[@biinari]: https://github.com/biinari | ||
[@barunio]: https://github.com/barunio | ||
[@molawson]: https://github.com/molawson | ||
[@wndhydrnt]: https://github.com/wndhydrnt | ||
[@ggilder]: https://github.com/ggilder | ||
[@salbertson]: https://github.com/salbertson | ||
[@camilleldn]: https://github.com/camilleldn | ||
[@mcls]: https://github.com/mcls | ||
[@yous]: https://github.com/yous | ||
[@vrthra]: https://github.com/vrthra | ||
[@SkuliOskarsson]: https://github.com/SkuliOskarsson | ||
[@jspanjers]: https://github.com/jspanjers | ||
[@sch1zo]: https://github.com/sch1zo | ||
[@smangelsdorf]: https://github.com/smangelsdorf | ||
[@mvz]: https://github.com/mvz | ||
[@jfelchner]: https://github.com/jfelchner | ||
[@janraasch]: https://github.com/janraasch | ||
[@jcarbo]: https://github.com/jcarbo | ||
[@oneamtu]: https://github.com/oneamtu | ||
[@toy]: https://github.com/toy | ||
[@Koronen]: https://github.com/Koronen | ||
[@blainesch]: https://github.com/blainesch | ||
[@marxarelli]: https://github.com/marxarelli | ||
[@katieschilling]: https://github.com/katieschilling | ||
[@kakutani]: https://github.com/kakutani | ||
[@rrosenblum]: https://github.com/rrosenblum | ||
[@mattjmcnaughton]: https://github.com/mattjmcnaughton | ||
[@huerlisi]: https://github.com/huerlisi | ||
[@volkert]: https://github.com/volkert | ||
[@lumeet]: https://github.com/lumeet | ||
[@mmozuras]: https://github.com/mmozuras | ||
[@d4rk5eed]: https://github.com/d4rk5eed | ||
[@cshaffer]: https://github.com/cshaffer | ||
[@eitoball]: https://github.com/eitoball | ||
[@iainbeeston]: https://github.com/iainbeeston | ||
[@pimterry]: https://github.com/pimterry | ||
[@palkan]: https://github.com/palkan | ||
[@jdoconnor]: https://github.com/jdoconnor | ||
[@meganemura]: https://github.com/meganemura | ||
[@zvkemp]: https://github.com/zvkemp | ||
[@vassilevsky]: https://github.com/vassilevsky | ||
[@gerry3]: https://github.com/gerry3 | ||
[@ypresto]: https://github.com/ypresto | ||
[@clowder]: https://github.com/clowder | ||
[@mudge]: https://github.com/mudge | ||
[@mzp]: https://github.com/mzp | ||
[@bankair]: https://github.com/bankair | ||
[@crimsonknave]: https://github.com/crimsonknave | ||
[@renuo]: https://github.com/renuo | ||
[@sdeframond]: https://github.com/sdeframond | ||
[@til]: https://github.com/til | ||
[@carhartl]: https://github.com/carhartl | ||
[@dylandavidson]: https://github.com/dylandavidson | ||
[@tmr08c]: https://github.com/tmr08c | ||
[@hbd225]: https://github.com/hbd225 | ||
[@l8nite]: https://github.com/l8nite | ||
[@sumeet]: https://github.com/sumeet | ||
[@ojab]: https://github.com/ojab | ||
[@chastell]: https://github.com/chastell | ||
[@glasnt]: https://github.com/glasnt | ||
[@crazydog115]: https://github.com/crazydog115 | ||
[@RGBD]: https://github.com/RGBD | ||
[@panthomakos]: https://github.com/panthomakos | ||
[@matugm]: https://github.com/matugm | ||
[@m1foley]: https://github.com/m1foley | ||
[@tejasbubane]: https://github.com/tejasbubane | ||
[@bmorrall]: https://github.com/bmorrall | ||
[@fphilipe]: https://github.com/fphilipe | ||
[@gotrevor]: https://github.com/gotrevor | ||
[@awwaiid]: https://github.com/awwaiid | ||
[@segiddins]: https://github.com/segiddins | ||
[@urbanautomaton]: https://github.com/urbanautomaton.com | ||
[@unmanbearpig]: https://github.com/unmanbearpig | ||
[@maxjacobson]: https://github.com/maxjacobson | ||
[@sliuu]: https://github.com/sliuu | ||
[@edmz]: https://github.com/edmz | ||
[@syndbg]: https://github.com/syndbg | ||
[@wli]: https://github.com/wli | ||
[@caseywebdev]: https://github.com/caseywebdev | ||
[@MGerrior]: https://github.com/MGerrior | ||
[@imtayadeway]: https://github.com/imtayadeway | ||
[@mrfoto]: https://github.com/mrfoto | ||
[@karreiro]: https://github.com/karreiro | ||
[@dreyks]: https://github.com/dreyks | ||
[@hmadison]: https://github.com/hmadison | ||
[@miquella]: https://github.com/miquella | ||
[@jhansche]: https://github.com/jhansche | ||
[@cornelius]: https://github.com/cornelius | ||
[@eagletmt]: https://github.com/eagletmt | ||
[@apiology]: https://github.com/apiology | ||
[@alexdowad]: https://github.com/alexdowad | ||
[@minustehbare]: https://github.com/minustehbare | ||
[@tansaku]: https://github.com/tansaku | ||
[@ptrippett]: https://github.com/ptrippett | ||
[@br3nda]: https://github.com/br3nda | ||
[@jujugrrr]: https://github.com/jujugrrr | ||
[@sometimesfood]: https://github.com/sometimesfood | ||
[@cgriego]: https://github.com/cgriego | ||
[@savef]: https://github.com/savef | ||
[@volmer]: https://github.com/volmer | ||
[@domcleal]: https://github.com/domcleal | ||
[@codebeige]: https://github.com/codebeige | ||
[@weh]: https://github.com/weh | ||
[@bfontaine]: https://github.com/bfontaine | ||
[@jawshooah]: https://github.com/jawshooah | ||
[@DNNX]: https://github.com/DNNX | ||
[@mvidner]: https://github.com/mvidner | ||
[@mattparlane]: https://github.com/mattparlane | ||
[@drenmi]: https://github.com/drenmi | ||
[@stormbreakerbg]: https://github.com/stormbreakerbg | ||
[@owst]: https://github.com/owst | ||
[@seikichi]: https://github.com/seikichi | ||
[@madwort]: https://github.com/madwort | ||
[@annih]: https://github.com/annih | ||
[@mmcguinn]: https://github.com/mmcguinn | ||
[@pocke]: https://github.com/pocke | ||
[@prsimp]: https://github.com/prsimp | ||
[@ptarjan]: https://github.com/ptarjan | ||
[@jweir]: https://github.com/jweir | ||
[@Fryguy]: https://github.com/Fryguy | ||
[@mikegee]: https://github.com/mikegee | ||
[@tbrisker]: https://github.com/tbrisker | ||
[@necojackarc]: https://github.com/necojackarc | ||
[@laurelfan]: https://github.com/laurelfan | ||
[@amuino]: https://github.com/amuino | ||
[@dylanahsmith]: https://github.com/dylanahsmith | ||
[@gerrywastaken]: https://github.com/gerrywastaken | ||
[@bolshakov]: https://github.com/bolshakov | ||
[@jastkand]: https://github.com/jastkand | ||
[@graemeboy]: https://github.com/graemeboy | ||
[@akihiro17]: https://github.com/akihiro17 | ||
[@magni-]: https://github.com/magni- | ||
[@NobodysNightmare]: https://github.com/NobodysNightmare | ||
[@gylaz]: https://github.com/gylaz | ||
[@tjwp]: https://github.com/tjwp | ||
[@neodelf]: https://github.com/neodelf | ||
[@josh]: https://github.com/josh | ||
[@natalzia-paperless]: https://github.com/natalzia-paperless | ||
[@jules2689]: https://github.com/jules2689 | ||
[@giannileggio]: https://github.com/giannileggio | ||
[@deivid-rodriguez]: https://github.com/deivid-rodriguez | ||
[@pclalv]: https://github.com/pclalv | ||
[@flexoid]: https://github.com/flexoid | ||
[@sgringwe]: https://github.com/sgringwe |