-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gemify Node & NodePattern #7735
Comments
I think my biggest concern now might be how much overhead this adds in terms of fixing bugs related to the node patterns or node extensions in RuboCop Core and its extensions. On another note, I think something like |
Our extension has little to do with code parsing and a lot more with the
Yep, that's true. The AST functionality is relatively stable these days, so we can probably live with the overhead, though. @marcandre I'm fine with the points you've outlined. |
Actually, thinking a bit more about it, it might be easier when RuboCop Core and extensions all use this dependency, as they can upgrade separately.
Good point. 👍 |
So I have managed to split I have a reasonably easy process that can redo the split from scratch given a fresh rubocop repo, so whenever we are ready to proceed it is easy to do so. It uses For developing purposes, if the two repositories What I can't do:
Let me know what else I can do |
@marcandre Thanks for working on this! I'll invite you now to our GitHub org, create the repo and register the gem name. We're about to cut RuboCop 1.0 later this week, so it'd be nice if we dealt with the extraction before this. |
Sounds great. Can't see the invite though. |
@marcandre You should see it now. The repo is also created. I'll register the gem name in a moment. |
Ah, actually it seems that I'll have to push the gem to register it, so I guess I'll do this after you import the code to the |
Done |
Gem pushed. I guess we'll go pretty quickly from 0.0.1 to 1.0.0 on this one. :-) |
Yeah, that's the plan. I'll see if I can setup the actions properly. |
I would like to release rubocop-ast |
Done. |
Awesome, thank you |
I'd like to resurrect #6686 to isolate
RuboCop::AST::*
andRuboCop::NodePattern
in its own separate gem.I'm proposing:
RuboCop::AST::Node
andRuboCop::NodePattern
in the same gemrubocop-ast
require 'rubocop-ast'
would not do anything besides (auto-)loading the relevant classes.RuboCop
's.rubocop-ast
gem.@jonatas has offered to help.
I've created a temporary repository to process the split. It has
rubocop
andrubocop-ast
as two submodules.I'd appreciate it very much if the powers that be let me know if there's anything they would like done differently.
The text was updated successfully, but these errors were encountered: