Crash in Style/StringConcatenation

[ghiculescu]

Style/StringConcatenation crashes on the following line. You can replicate by making a file with just this line as its contents.

arr.join("") + "\r\n" + (arr2.empty? ? "" : arr2.join("") + "\r\n")

Backtrace:

Parser::Source::TreeRewriter detected clobbering
/Users/alex/.rvm/gems/ruby-2.7.1/gems/parser-2.7.1.4/lib/parser/source/tree_rewriter.rb:400:in `trigger_policy'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/parser-2.7.1.4/lib/parser/source/tree_rewriter.rb:387:in `enforce_policy'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/parser-2.7.1.4/lib/parser/source/tree_rewriter/action.rb:233:in `call'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/parser-2.7.1.4/lib/parser/source/tree_rewriter/action.rb:233:in `swallow'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/parser-2.7.1.4/lib/parser/source/tree_rewriter/action.rb:97:in `with'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/parser-2.7.1.4/lib/parser/source/tree_rewriter/action.rb:124:in `place_in_hierarchy'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/parser-2.7.1.4/lib/parser/source/tree_rewriter/action.rb:106:in `do_combine'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/parser-2.7.1.4/lib/parser/source/tree_rewriter/action.rb:117:in `place_in_hierarchy'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/parser-2.7.1.4/lib/parser/source/tree_rewriter/action.rb:131:in `block in combine_children'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/parser-2.7.1.4/lib/parser/source/tree_rewriter/action.rb:130:in `each'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/parser-2.7.1.4/lib/parser/source/tree_rewriter/action.rb:130:in `inject'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/parser-2.7.1.4/lib/parser/source/tree_rewriter/action.rb:130:in `combine_children'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/parser-2.7.1.4/lib/parser/source/tree_rewriter/action.rb:221:in `merge'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/parser-2.7.1.4/lib/parser/source/tree_rewriter/action.rb:104:in `do_combine'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/parser-2.7.1.4/lib/parser/source/tree_rewriter/action.rb:30:in `combine'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/parser-2.7.1.4/lib/parser/source/tree_rewriter.rb:143:in `merge!'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/rubocop-0.91.1/lib/rubocop/cop/base.rb:273:in `apply_correction'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/rubocop-0.91.1/lib/rubocop/cop/base.rb:355:in `attempt_correction'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/rubocop-0.91.1/lib/rubocop/cop/base.rb:339:in `correct'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/rubocop-0.91.1/lib/rubocop/cop/base.rb:126:in `add_offense'
/Users/alex/.rvm/gems/ruby-2.7.1/gems/rubocop-0.91.1/lib/rubocop/cop/style/string_concatenation.rb:44:in `on_send'

RuboCop version

Include the output of rubocop -V or bundle exec rubocop -V if using Bundler. Here's an example:

$ [bundle exec] rubocop -V
0.91.1 (using Parser 2.7.1.4, rubocop-ast 0.4.2, running on ruby 2.7.1 x86_64-darwin19)