Fix SymbolProc autocorrect with multiple offenses #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffcarbs
force-pushed
the
fix-multiple-symbol-proc
branch
2 times, most recently
from
443dace
to
dfd70cc
Compare
When there were multiple offenses for the SymbolProc cop (e.g.
`coll.map { |s| s.upcase }.map { |s| s.downcase }`) the cop would
raise an error: `Parser::Source::Rewriter detected clobbering`.
Digging into relevant commits I found some inspiration from
@jonas054 (rubocop#569). This commit changes the autocorrect for the
`SymbolProc` cop to be a little more precise in determining what to
correct. There's a new spec that I wrote that fails on master and
passes on this branch.
jeffcarbs
force-pushed
the
fix-multiple-symbol-proc
branch
from
dfd70cc
to
ed95a43
Compare
|
👍 Looks good! |
bbatsov
added a commit
that referenced
this pull request
Nov 23, 2014
Fix SymbolProc autocorrect with multiple offenses
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there were multiple offenses for the SymbolProc cop (e.g.
coll.map { |s| s.upcase }.map { |s| s.downcase }) the cop wouldraise an error:
Parser::Source::Rewriter detected clobbering.Digging into relevant commits I found some inspiration from
@jonas054 (#569). This commit changes the autocorrect for the
SymbolProc cop to be a little more precise in determining what to
correct. There's a new spec that I wrote that fails on master and
passes on this branch.