Fix autocorrect clobbering #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. You'll have to rebase, though. |
The StringLiterals cop shold not report offences for character literals.
Calling corrector.replace with rather big ranges increases the risk for clobbering, i.e. conflicting corrections. It's better to use insert_before, insert_after, and remove when possible, and replace only when it's relevant.
|
Rebased. |
|
Hmm. What happened with the Rubinius run on Travis? |
jeffcarbs
added a commit
to jeffcarbs/rubocop
that referenced
this pull request
Nov 23, 2014
When there were multiple offenses for the SymbolProc cop (e.g.
`coll.map { |s| s.upcase }.map { |s| s.downcase }`) the cop would
raise an error: `Parser::Source::Rewriter detected clobbering`.
Digging into relevant commits I found some inspiration from
@jonas054 (rubocop#569). This commit changes the autocorrect for the
`SymbolProc` cop to be a little more precise in determining what to
correct. There's a new spec that I wrote that fails on master and
passes on this branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #553 and testing
--auto-correcton lage code bases, I noticed that we would get errors from Parser because two corrections would conflict with each other. It seems that we have been rather lazy when implementing our auto-corrections, using thereplacemethod everywhere. This PR tries to fix the problem by using more precise corrections on smaller ranges. There are also a couple of cases of double reporting that had to be fixed, since they would also lead to clobbering errors.