New cop Rails/SafeNavigation #3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rrosenblum: I've been looking at the ASTs for some different variations, and I share your premonition. 😅 |
|
@Drenmi, if you have any sharable information, I would be happy to see what you have. I think the style cop is going to have to be something that we iterate on over time. To start out, the safest changes will be those that use |
|
@rrosenblum: I'll share anything I have in #2428, as soon as I get some spare time (which may not be until a couple of weeks from now. 😞 ) |
Neodelf
pushed a commit
to Neodelf/rubocop
that referenced
this pull request
Oct 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to revive this effort. The style cop for safe navigation is going to be much more difficult than the Rails cop was.