New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cop Rails/SafeNavigation #3417

Merged
merged 1 commit into from Aug 16, 2016

Conversation

Projects
None yet
3 participants
@rrosenblum
Contributor

rrosenblum commented Aug 16, 2016

I decided to revive this effort. The style cop for safe navigation is going to be much more difficult than the Rails cop was.

@bbatsov bbatsov merged commit 9a45bad into rubocop-hq:master Aug 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Drenmi

This comment has been minimized.

Show comment
Hide comment
@Drenmi

Drenmi Aug 17, 2016

Collaborator

@rrosenblum: I've been looking at the ASTs for some different variations, and I share your premonition. 😅

Collaborator

Drenmi commented Aug 17, 2016

@rrosenblum: I've been looking at the ASTs for some different variations, and I share your premonition. 😅

@rrosenblum

This comment has been minimized.

Show comment
Hide comment
@rrosenblum

rrosenblum Aug 17, 2016

Contributor

@Drenmi, if you have any sharable information, I would be happy to see what you have. I think the style cop is going to have to be something that we iterate on over time. To start out, the safest changes will be those that use respond_to?.

Contributor

rrosenblum commented Aug 17, 2016

@Drenmi, if you have any sharable information, I would be happy to see what you have. I think the style cop is going to have to be something that we iterate on over time. To start out, the safest changes will be those that use respond_to?.

@Drenmi

This comment has been minimized.

Show comment
Hide comment
@Drenmi

Drenmi Aug 18, 2016

Collaborator

@rrosenblum: I'll share anything I have in #2428, as soon as I get some spare time (which may not be until a couple of weeks from now. 😞 )

Collaborator

Drenmi commented Aug 18, 2016

@rrosenblum: I'll share anything I have in #2428, as soon as I get some spare time (which may not be until a couple of weeks from now. 😞 )

Neodelf added a commit to Neodelf/rubocop that referenced this pull request Oct 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment