Allow db to allowed names of Naming/UncommunicativeMethodParamName cop in default config
#6137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelabon
changed the title
db as method paramter in default configdb to allowed names of Naming/UncommunicativeMethodParamName cop in default config
michaelabon
force-pushed
the
allow-db-in-naming-uncommunicative
branch
2 times, most recently
from
27e6667
to
b08cfa8
Compare
koic
reviewed
Jul 28, 2018
CHANGELOG.md
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| ## master (unreleased) | |||
|
|
|||
| * [#6137](https://github.com/rubocop-hq/rubocop/pull/6137): Allow `db` to allowed names of `Naming/UncommunicativeMethodParamName` cop in default config. ([@mkenyon][]) | |||
There was a problem hiding this comment.
Would you please add the ### Changes section?
## master (unreleased)
+ ### Changes
+
* [#6137](https://github.com/rubocop-hq/rubocop/pull/6137): Allow `db` to allowed names of `Naming/UncommunicativeMethodParamName` cop in default config. ([@mkenyon][])
michaelabon
force-pushed
the
allow-db-in-naming-uncommunicative
branch
from
b08cfa8
to
682cc3e
Compare
koic
reviewed
Jul 31, 2018
CHANGELOG.md
Outdated
| @@ -3491,3 +3495,5 @@ | |||
| [@kenman345]: https://github.com/kenman345 | |||
| [@nijikon]: https://github.com/nijikon | |||
| [@mikeyhew]: https://github.com/mikeyhew | |||
| [@kenman345]: https://github.com/kenman345 | |||
There was a problem hiding this comment.
CI has failed. Would you please delete this line?
https://travis-ci.org/rubocop-hq/rubocop/jobs/410116964#L1119
[@mikeyhew]: https://github.com/mikeyhew
-[@kenman345]: https://github.com/kenman345
[@mkenyon]: https://github.com/mkenyonAdd `db` to AllowedNames in default configuration for cop Naming/UncommunicativeMethodParamName in order to allow talking about or configuring a particular database.
michaelabon
force-pushed
the
allow-db-in-naming-uncommunicative
branch
from
682cc3e
to
03f66a6
Compare
|
This looks like adding a reasonable name 🌟 Thanks for your first time contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
dbto AllowedNames in default configuration for copNaming/UncommunicativeMethodParamName in order to allow talking about or
configuring a particular database.
I think that using the shorter
dbis unambiguous while still being descriptive, rather than writing outdatabase.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
rake defaultorrake parallel. It executes all tests and RuboCop for itself, and generates the documentation.