Fix false positives for Lint/ParenthesesAsGroupedExpression #8039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following false positive for
Lint/ParenthesesAsGroupedExpression
This PR adds some reproduction tests.
I was initially thinking of changing the auto-correct to produce things such as
func((x) || y)
andfunc((x).func.func.func.func.func)
, but since we probably do not wanteq (x).to_i
to become suddenlyeq((x).to_i)
(#7909), I went with ignoring these pasterns. This is because the current auto-correct behavior breaks the code for these paterns. Please do tell me if we would prefer going in another direction 🙏I'm not very comfortable with these language nodes, so please treat this PR as an humble attempt 🙏
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.