Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support autocorrection for `Lint/RaiseException` #8169

Merged

Conversation

@koic
Copy link
Member

koic commented Jun 19, 2020

This PR supports autocorrection for Lint/RaiseException.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
@koic koic force-pushed the koic:support_autocorrect_for_raise_exception branch from d232f40 to eede319 Jun 20, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 20, 2020

I guess we should mark this cop as unsafe.

@koic koic force-pushed the koic:support_autocorrect_for_raise_exception branch 2 times, most recently from 1d50bbc to 35d3afb Jun 21, 2020
@koic
Copy link
Member Author

koic commented Jun 21, 2020

Sure. I will open another PR to have it add an entry that marks it unsafe to the changelog.

koic added a commit to koic/rubocop that referenced this pull request Jun 21, 2020
Follow up rubocop-hq#8169 (comment).

`Lint/RaiseException` cop is usafe due to incompatibility
between bad and good cases.

## bad case

```console
% cat /tmp/example_for_exception.rb
begin
  raise Exception
rescue
  puts 'Handle exception'
end

% ruby example_for_exception.rb
example_for_exception.rb:2:in `<main>': Exception (Exception)
```

## good case

```console
% cat example_for_starndard_error.rb
begin
  raise StandardError
rescue
  puts 'Handle exception'
end

% ruby /tmp/example_for_starndard_error.rb
Handle exception
```
koic added a commit to koic/rubocop that referenced this pull request Jun 21, 2020
Follow up rubocop-hq#8169 (comment).

`Lint/RaiseException` cop is unsafe due to incompatibility
between bad and good cases.

## bad case

```console
% cat /tmp/example_for_exception.rb
begin
  raise Exception
rescue
  puts 'Handle exception'
end

% ruby example_for_exception.rb
example_for_exception.rb:2:in `<main>': Exception (Exception)
```

## good case

```console
% cat example_for_starndard_error.rb
begin
  raise StandardError
rescue
  puts 'Handle exception'
end

% ruby /tmp/example_for_starndard_error.rb
Handle exception
```
@koic koic mentioned this pull request Jun 21, 2020
7 of 8 tasks complete
bbatsov added a commit that referenced this pull request Jun 21, 2020
Follow up #8169 (comment).

`Lint/RaiseException` cop is unsafe due to incompatibility
between bad and good cases.

## bad case

```console
% cat /tmp/example_for_exception.rb
begin
  raise Exception
rescue
  puts 'Handle exception'
end

% ruby example_for_exception.rb
example_for_exception.rb:2:in `<main>': Exception (Exception)
```

## good case

```console
% cat example_for_starndard_error.rb
begin
  raise StandardError
rescue
  puts 'Handle exception'
end

% ruby /tmp/example_for_starndard_error.rb
Handle exception
```
@koic koic force-pushed the koic:support_autocorrect_for_raise_exception branch 2 times, most recently from 1a73e28 to db93b8e Jun 21, 2020
This PR supports autocorrection for `Lint/RaiseException`.
@koic koic force-pushed the koic:support_autocorrect_for_raise_exception branch from db93b8e to d197c84 Jun 21, 2020
@koic koic merged commit e013060 into rubocop-hq:master Jun 21, 2020
26 checks passed
26 checks passed
windows 2.4
Details
windows 2.5
Details
windows 2.6
Details
windows 2.7
Details
windows mingw
Details
ci/circleci: cc-setup Your tests passed on CircleCI!
Details
ci/circleci: cc-upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: documentation-checks Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-rubocop Your tests passed on CircleCI!
Details
ci/circleci: jruby-9.2-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.6-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.7-spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-ascii_spec Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-rubocop Your tests passed on CircleCI!
Details
ci/circleci: ruby-head-spec Your tests passed on CircleCI!
Details
@koic koic deleted the koic:support_autocorrect_for_raise_exception branch Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.