Add new "Identity Comparison" rule #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Aug 8, 2020
README.adoc
Outdated
| @@ -2198,6 +2198,19 @@ something = something && something.downcase | |||
| something &&= something.downcase | |||
| ---- | |||
|
|
|||
| === Equal Object Identifier [[equal-object-id]] | |||
There was a problem hiding this comment.
I think we can name this "Identity Comparison", as the other form of comparison is "Value Comparison" (the one normally done with ==).
bbatsov
reviewed
Aug 8, 2020
README.adoc
Outdated
| @@ -2198,6 +2198,19 @@ something = something && something.downcase | |||
| something &&= something.downcase | |||
| ---- | |||
|
|
|||
| === Equal Object Identifier [[equal-object-id]] | |||
|
|
|||
| Prefer `equal?` over `==` when comparing `object_id`. `Object#equal?` method is provided to compare objects for identity, and comparing objects for equality using `Object#==` does not require redundant `object_id` to be repeated. | |||
There was a problem hiding this comment.
comparing objects for equality using
Object#==does not require redundantobject_idto be repeated.
I think this part can be worded better, or changed to something like "and in contrast Object#== is provided for the purpose of doing value comparison" or something along those lines.
This PR adds new "Equal Object Identifier" rule that prefers `equal?` over `==` when comparing `object_id`. `Object#equal?` method is provided to compare objects for identity, and comparing objects for equality using `Object#==` does not require redundant `object_id` to be repeated. ```ruby # bad foo.object_id == bar.object_id # good foo.equal?(bar) ```
koic
changed the title
koic
force-pushed
the
add_new_equal_object_id_rule
branch
from
f0ee4b3
to
3ac01f4
Compare
|
Thank you for your review and sophisticated suggestions! I updated this PR. |
|
You're welcome! |
|
Created #836 as a followup... |
koic
added a commit
to koic/rubocop
that referenced
this pull request
Sep 11, 2020
Follow rubocop/ruby-style-guide#835. This PR adds new `Lint/IdentityComparison` cop. ```ruby # bad foo.object_id == bar.object_id # good foo.equal?(bar) ``` The cop prefers `equal?` over `==` when comparing `object_id`. `Object#equal?` is provided to compare objects for identity, and in contrast `Object#==` is provided for the purpose of doing value comparison.
8 tasks
bbatsov
pushed a commit
to rubocop/rubocop
that referenced
this pull request
Sep 11, 2020
Follow rubocop/ruby-style-guide#835. This PR adds new `Lint/IdentityComparison` cop. ```ruby # bad foo.object_id == bar.object_id # good foo.equal?(bar) ``` The cop prefers `equal?` over `==` when comparing `object_id`. `Object#equal?` is provided to compare objects for identity, and in contrast `Object#==` is provided for the purpose of doing value comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new "Equal Object Identifier" rule that prefers
equal?over==when comparingobject_id.Object#equal?method is provided to compare objects for identity, and comparing objects for equality usingObject#==does not requireredundant
object_idto be repeated.