Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added section on the declaration order of subject, let!/let and before/after hooks #135

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

schinery
Copy link
Contributor

@schinery schinery commented Oct 4, 2023

Added section on the declaration order of subject, let!/let and before/after hooks to the Example Group Structure section.

Screenshot 2023-10-05 at 07 50 10

Also, moved [Leading Subject] to the Example Group Structure section, as mentioned below.

Screenshot 2023-10-05 at 07 46 28

Resolves #134

@schinery schinery changed the title Updated and moved Leading Subject to include position of let and before/after blocks Updated and renamed Leading Subject to include position of let and before/after blocks Oct 4, 2023
@schinery schinery changed the title Updated and renamed Leading Subject to include position of let and before/after blocks Updated and renamed Leading Subject to include order of let and before/after blocks Oct 4, 2023
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this!

Suggestions:

  1. Keep the existing leading-subject guideline as is. There are external resources linking to guidelines, and we don’t want to break them. There’s a workaround to specify a legance anchor name.
  2. I’d move both guidelines to the example group structure section.
  3. Let’s call them “hooks”

@schinery schinery changed the title Updated and renamed Leading Subject to include order of let and before/after blocks Added section on the declaration order of subject, let!/let and before/after hooks Oct 5, 2023
@schinery
Copy link
Contributor Author

schinery commented Oct 5, 2023

Thanks for handling this!

Suggestions:

  1. Keep the existing leading-subject guideline as is. There are external resources linking to guidelines, and we don’t want to break them. There’s a workaround to specify a legance anchor name.
  2. I’d move both guidelines to the example group structure section.
  3. Let’s call them “hooks”

@pirj hoping I've done these suggestions correctly. Please let me know if this needs any more amends.

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
@pirj pirj merged commit 7557420 into rubocop:master Oct 10, 2023
3 checks passed
@pirj
Copy link
Member

pirj commented Oct 10, 2023

Thank you, @schinery !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

let and let! to be declared before before and after blocks?
2 participants