Fix #value for a dstr node.
#167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvandersluis
force-pushed
the
dstr-value
branch
2 times, most recently
from
55fa88f
to
bffe9b5
Compare
|
Seems like a good addition. Would you add a Changelog entry (same way as the main gem) please? |
|
Definitely! |
|
Still can't see it... |
dvandersluis
force-pushed
the
dstr-value
branch
from
bffe9b5
to
060e5b3
Compare
|
@marcandre updated now! |
|
Thanks! |
|
@dvandersluis Thanks for fixing this. I had actually been working around it. |
tas50
added a commit
to chef/cookstyle
that referenced
this pull request
Jan 29, 2021
This was fixed in rubocop-ast so we don't have to get the source anymore to get the actual string. rubocop/rubocop-ast#167 Signed-off-by: Tim Smith <tsmith@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dstrnodes previously usedStrNode, which exposes#value; however, it just returns the first child, which is a node, not a string value.This changes
dstrs to have their own node class that inherits fromStrNodebut overrides#valueas to get the actual string value of the node (including any interpolations).ie.