Handle encoding error from the parser gem #289
Conversation
|
Errors in prism are due to the same reason that rubocop/rubocop#12822 was made. |
Temporarily resolved in #290. Can you rebase with the latest master branch? |
CHANGELOG.md
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| ## master (unreleased) | |||
|
|
|||
| * [#289](https://github.com/rubocop/rubocop-ast/pull/289): Fix an error during parsing when encountering unknown encodings in the encoding magic comment. ([@Earlopain][]) | |||
There was a problem hiding this comment.
Can you add an changelog entry file instead?
https://github.com/rubocop/rubocop-ast/blob/master/CONTRIBUTING.md#changelog-entry-format
There was a problem hiding this comment.
Yeah, sure. I looked like this one isn't done here. I added a .gitkeep file to the changelog folder to make it more clear, like in the RuboCop repo.
There was a problem hiding this comment.
I added a
.gitkeepfile to the changelog folder to make it more clear, like in the RuboCop repo.
Can you separate the commit as they serve different purposes? It's also fine to send a separate PR.
This specific exception has been added only in the most recent release. Previously it threw an `ArgumentError`.
Earlopain
force-pushed
the
unknown-encoding-error
branch
from
0699b97
to
16a4012
Compare
This may be of interest to you. I openend ruby/prism#2741 to align it with the parser gem. Raising a syntax error for bare yields etc. breaks extensions like |
|
Released in 1.31.3 |
This specific exception has been added only in the most recent release. Previously it threw an
ArgumentError. PR in parser: whitequark/parser#999This is not really a syntax error: Running a file with an encoding like that produces the following output:
RuboCop will report it as one though, since it will pick up the error from
parser_error. I don't believe it is worth it to add extra logic to make a distinction here.