Fix a false positive for FactoryBot/CreateList

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Master (Unreleased)
 
+- Fix a false positive for `FactoryBot/CreateList` when create call does have method calls and repeat multiple times with other argument. ([@ydah])
+
 ## 2.25.0 (2024-01-04)
 
 - Fix a false positive for `FactoryBot/FactoryNameStyle` when namespaced models. ([@ydah])

lib/rubocop/cop/factory_bot/create_list.rb

@@ -90,7 +90,7 @@ class CreateList < ::RuboCop::Cop::Base # rubocop:disable Metrics/ClassLength
 
         # @!method arguments_include_method_call?(node)
         def_node_matcher :arguments_include_method_call?, <<~PATTERN
-          (send #factory_call? :create sym `(send ...))
+          (send #factory_call? :create sym ... `(send ...))
         PATTERN
 
         # @!method factory_call(node)

spec/rubocop/cop/factory_bot/create_list_spec.rb

@@ -84,6 +84,13 @@
       RUBY
     end
 
+    it 'ignores n.times when create call does have method calls ' \
+       'and repeat multiple times with other argument' do
+      expect_no_offenses(<<~RUBY)
+        3.times { |n| create :user, :admin, repositories_count: rand }
+      RUBY
+    end
+
     it 'ignores n.times when create call does have method calls ' \
        'and not repeat' do
       expect_no_offenses(<<~RUBY)
@@ -138,17 +145,6 @@
       RUBY
     end
 
-    it 'flags usage of n.times with keyword arguments' do
-      expect_offense(<<~RUBY)
-        5.times { create :user, :trait, key: val }
-        ^^^^^^^ Prefer create_list.
-      RUBY
-
-      expect_correction(<<~RUBY)
-        create_list :user, 5, :trait, key: val
-      RUBY
-    end
-
     it 'flags usage of n.times with block argument' do
       expect_offense(<<~RUBY)
         3.times do