Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error occurred for FactoryBot/IdSequence when sequence with non-symbol argument or without argument #98

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented Jan 4, 2024

Fix: #80


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • [-] Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@ydah ydah changed the title Fix an error occurred for FactoryBot/IdSequence when sequence with non-symbol argment or without argument Fix an error occurred for FactoryBot/IdSequence when sequence with non-symbol argument or without argument Jan 4, 2024
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

spec/rubocop/cop/factory_bot/id_sequence_spec.rb Outdated Show resolved Hide resolved
@ydah ydah force-pushed the fix80 branch 2 times, most recently from 91eb872 to 5908d4b Compare January 5, 2024 14:43
…h non-symbol argment or without argument

Fix: #80
@ydah ydah merged commit dd523d9 into master Jan 6, 2024
24 checks passed
@ydah ydah deleted the fix80 branch January 6, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FactoryBot/IdSequence error occurred while cop was inspecting file
3 participants